Commit 22abdec4 authored by Natalia Tepluhina's avatar Natalia Tepluhina Committed by Phil Hughes

Squashed CE commits for cherrypicking

- all commits are squashed
- fixed e2e tests
- applied reviewer fixes
parent ba40db50
...@@ -171,8 +171,6 @@ describe 'Merge request > Batch comments', :js do ...@@ -171,8 +171,6 @@ describe 'Merge request > Batch comments', :js do
expect(page).to have_content('1/1 thread resolved') expect(page).to have_content('1/1 thread resolved')
expect(page).to have_selector('.line-resolve-btn.is-active') expect(page).to have_selector('.line-resolve-btn.is-active')
end end
expect_empty_local_draft
end end
end end
...@@ -216,8 +214,6 @@ describe 'Merge request > Batch comments', :js do ...@@ -216,8 +214,6 @@ describe 'Merge request > Batch comments', :js do
expect(page).to have_content('0/1 thread resolved') expect(page).to have_content('0/1 thread resolved')
expect(page).to have_selector('.line-resolve-btn.is-disabled') expect(page).to have_selector('.line-resolve-btn.is-disabled')
end end
expect_empty_local_draft
end end
end end
end end
...@@ -253,7 +249,7 @@ describe 'Merge request > Batch comments', :js do ...@@ -253,7 +249,7 @@ describe 'Merge request > Batch comments', :js do
end end
def write_reply_to_discussion(button_text: 'Start a review', text: 'Line is wrong', resolve: false, unresolve: false) def write_reply_to_discussion(button_text: 'Start a review', text: 'Line is wrong', resolve: false, unresolve: false)
page.within('.discussion-reply-holder') do page.within(first('.diff-files-holder .discussion-reply-holder')) do
click_button('Reply...') click_button('Reply...')
fill_in('note_note', with: text) fill_in('note_note', with: text)
...@@ -271,10 +267,3 @@ def write_reply_to_discussion(button_text: 'Start a review', text: 'Line is wron ...@@ -271,10 +267,3 @@ def write_reply_to_discussion(button_text: 'Start a review', text: 'Line is wron
wait_for_requests wait_for_requests
end end
def expect_empty_local_draft
page.within('.discussion-reply-holder') do
click_button('Reply...')
expect(find('#note_note').value).to eq('')
end
end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment