Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
22abdec4
Commit
22abdec4
authored
Jul 03, 2019
by
Natalia Tepluhina
Committed by
Phil Hughes
Jul 03, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Squashed CE commits for cherrypicking
- all commits are squashed - fixed e2e tests - applied reviewer fixes
parent
ba40db50
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
12 deletions
+1
-12
ee/spec/features/merge_request/batch_comments_spec.rb
ee/spec/features/merge_request/batch_comments_spec.rb
+1
-12
No files found.
ee/spec/features/merge_request/batch_comments_spec.rb
View file @
22abdec4
...
@@ -171,8 +171,6 @@ describe 'Merge request > Batch comments', :js do
...
@@ -171,8 +171,6 @@ describe 'Merge request > Batch comments', :js do
expect
(
page
).
to
have_content
(
'1/1 thread resolved'
)
expect
(
page
).
to
have_content
(
'1/1 thread resolved'
)
expect
(
page
).
to
have_selector
(
'.line-resolve-btn.is-active'
)
expect
(
page
).
to
have_selector
(
'.line-resolve-btn.is-active'
)
end
end
expect_empty_local_draft
end
end
end
end
...
@@ -216,8 +214,6 @@ describe 'Merge request > Batch comments', :js do
...
@@ -216,8 +214,6 @@ describe 'Merge request > Batch comments', :js do
expect
(
page
).
to
have_content
(
'0/1 thread resolved'
)
expect
(
page
).
to
have_content
(
'0/1 thread resolved'
)
expect
(
page
).
to
have_selector
(
'.line-resolve-btn.is-disabled'
)
expect
(
page
).
to
have_selector
(
'.line-resolve-btn.is-disabled'
)
end
end
expect_empty_local_draft
end
end
end
end
end
end
...
@@ -253,7 +249,7 @@ describe 'Merge request > Batch comments', :js do
...
@@ -253,7 +249,7 @@ describe 'Merge request > Batch comments', :js do
end
end
def
write_reply_to_discussion
(
button_text:
'Start a review'
,
text:
'Line is wrong'
,
resolve:
false
,
unresolve:
false
)
def
write_reply_to_discussion
(
button_text:
'Start a review'
,
text:
'Line is wrong'
,
resolve:
false
,
unresolve:
false
)
page
.
within
(
'.discussion-reply-holder'
)
do
page
.
within
(
first
(
'.diff-files-holder .discussion-reply-holder'
)
)
do
click_button
(
'Reply...'
)
click_button
(
'Reply...'
)
fill_in
(
'note_note'
,
with:
text
)
fill_in
(
'note_note'
,
with:
text
)
...
@@ -271,10 +267,3 @@ def write_reply_to_discussion(button_text: 'Start a review', text: 'Line is wron
...
@@ -271,10 +267,3 @@ def write_reply_to_discussion(button_text: 'Start a review', text: 'Line is wron
wait_for_requests
wait_for_requests
end
end
def
expect_empty_local_draft
page
.
within
(
'.discussion-reply-holder'
)
do
click_button
(
'Reply...'
)
expect
(
find
(
'#note_note'
).
value
).
to
eq
(
''
)
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment