Merge branch 'ar-cleanup-protected-tags' into 'master'

Clean up protected tags

See merge request gitlab-org/gitlab!53924

app/assets/javascripts/protected_tags/constants.js

+import { s__ } from '~/locale';
+
+export const FAILED_TO_UPDATE_TAG_MESSAGE = s__('ProjectSettings|Failed to update tag!');

app/assets/javascripts/protected_tags/protected_tag_edit.js

-import { s__ } from '~/locale';
 import { deprecatedCreateFlash as flash } from '../flash';
 import axios from '../lib/utils/axios_utils';
 import ProtectedTagAccessDropdown from './protected_tag_access_dropdown';
+import { FAILED_TO_UPDATE_TAG_MESSAGE } from './constants';
 
 export default class ProtectedTagEdit {
   constructor(options) {
@@ -49,7 +49,7 @@ export default class ProtectedTagEdit {
         this.$allowedToCreateDropdownButton.enable();
 
         window.scrollTo({ top: 0, behavior: 'smooth' });
-        flash(s__('ProjectSettings|Failed to update tag!'));
+        flash(FAILED_TO_UPDATE_TAG_MESSAGE);
       });
   }
 }

ee/app/assets/javascripts/protected_tags/protected_tag_edit.js

@@ -2,7 +2,7 @@ import { find } from 'lodash';
 import AccessDropdown from '~/projects/settings/access_dropdown';
 import axios from '~/lib/utils/axios_utils';
 import { deprecatedCreateFlash as createFlash } from '~/flash';
-import { s__ } from '~/locale';
+import { FAILED_TO_UPDATE_TAG_MESSAGE } from '~/protected_tags/constants';
 import { ACCESS_LEVELS, LEVEL_TYPES } from './constants';
 
 export default class ProtectedTagEdit {
@@ -67,7 +67,7 @@ export default class ProtectedTagEdit {
       })
       .catch(() => {
         window.scrollTo({ top: 0, behavior: 'smooth' });
-        createFlash(s__('ProjectSettings|Failed to update tag!'));
+        createFlash(FAILED_TO_UPDATE_TAG_MESSAGE);
       });
   }