Use early return in lfs_token_check

242e77e0 · Kamil Trzcinski · dba227da · 242e77e0
Commit 242e77e0 authored Sep 20, 2016 by Kamil Trzcinski
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 10 deletions

lib/gitlab/auth.rb lib/gitlab/auth.rb +10 -10

No files found.
--- a/lib/gitlab/auth.rb
+++ b/lib/gitlab/auth.rb
@@ -113,18 +113,18 @@ module Gitlab
            User.by_login(login)
          end
-        if actor
+        return unless actor
-          token_handler = Gitlab::LfsToken.new(actor)
-          authentication_abilities =
+        token_handler = Gitlab::LfsToken.new(actor)
-            if token_handler.user?
-              full_authentication_abilities
-            else
-              read_authentication_abilities
-            end
-          Result.new(actor, nil, token_handler.type, authentication_abilities) if Devise.secure_compare(token_handler.value, password)
+        authentication_abilities =
-        end
+          if token_handler.user?
+            full_authentication_abilities
+          else
+            read_authentication_abilities
+          end
+        Result.new(actor, nil, token_handler.type, authentication_abilities) if Devise.secure_compare(token_handler.value, password)
      end
      def build_access_token_check(login, password)