Add reviewer comment

- Move help path to provide/inject
- translate text

app/assets/javascripts/pages/projects/forks/new/components/app.vue

@@ -14,18 +14,10 @@ export default {
       type: String,
       required: true,
     },
-    newGroupPath: {
-      type: String,
-      required: true,
-    },
     projectFullPath: {
       type: String,
       required: true,
     },
-    visibilityHelpPath: {
-      type: String,
-      required: true,
-    },
     projectId: {
       type: String,
       required: true,
@@ -68,9 +60,7 @@ export default {
     <div class="col-lg-9">
       <fork-form
         :endpoint="endpoint"
-        :new-group-path="newGroupPath"
         :project-full-path="projectFullPath"
-        :visibility-help-path="visibilityHelpPath"
         :project-id="projectId"
         :project-name="projectName"
         :project-path="projectPath"

app/assets/javascripts/pages/projects/forks/new/components/fork_form.vue

@@ -45,23 +45,23 @@ export default {
     GlFormRadioGroup,
     GlFormSelect,
   },
+  inject: {
+    newGroupPath: {
+      default: '',
+    },
+    visibilityHelpPath: {
+      default: '',
+    },
+  },
   props: {
     endpoint: {
       type: String,
       required: true,
     },
-    newGroupPath: {
-      type: String,
-      required: true,
-    },
     projectFullPath: {
       type: String,
       required: true,
     },
-    visibilityHelpPath: {
-      type: String,
-      required: true,
-    },
     projectId: {
       type: String,
       required: true,

app/assets/javascripts/pages/projects/forks/new/index.js

@@ -21,6 +21,10 @@ if (gon.features.forkProjectForm) {
   // eslint-disable-next-line no-new
   new Vue({
     el: mountElement,
+    provide: {
+      newGroupPath,
+      visibilityHelpPath,
+    },
     render(h) {
       return h(App, {
         props: {

app/views/projects/forks/new.html.haml

-- page_title _("ForkProject|Fork project")
+- page_title s_("ForkProject|Fork project")
 
 - if Feature.enabled?(:fork_project_form)
   #fork-groups-mount-element{ data: { fork_illustration: image_path('illustrations/project-create-new-sm.svg'),
@@ -15,15 +15,15 @@
   .row.gl-mt-3
     .col-lg-3
       %h4.gl-mt-0
-        = _("Fork project")
+        = s_("ForkProject|Fork project")
       %p
-        = _("A fork is a copy of a project.")
+        = s_("ForkProject|A fork is a copy of a project.")
         %br
-        = _('Forking a repository allows you to make changes without affecting the original project.')
+        = s_('ForkProject|Forking a repository allows you to make changes without affecting the original project.')
     .col-lg-9
       - if @own_namespace.present?
         .fork-thumbnail-container.js-fork-content
           %h5.gl-mt-0.gl-mb-0.gl-ml-3.gl-mr-3
-            = _("Select a namespace to fork the project")
+            = s_("ForkProject|Select a namespace to fork the project")
           = render 'fork_button', namespace: @own_namespace
       #fork-groups-mount-element{ data: { endpoint: new_project_fork_path(@project, format: :json) } }

locale/gitlab.pot

@@ -1315,9 +1315,6 @@ msgstr ""
 msgid "A file with '%{file_name}' already exists in %{branch} branch"
 msgstr ""
 
-msgid "A fork is a copy of a project."
-msgstr ""
-
 msgid "A group is a collection of several projects"
 msgstr ""
 
@@ -13306,6 +13303,9 @@ msgstr ""
 msgid "ForkProject|Select a namespace"
 msgstr ""
 
+msgid "ForkProject|Select a namespace to fork the project"
+msgstr ""
+
 msgid "ForkProject|The project can be accessed by any logged in user."
 msgstr ""
 
@@ -13324,9 +13324,6 @@ msgstr ""
 msgid "ForkedFromProjectPath|Forked from an inaccessible project"
 msgstr ""
 
-msgid "Forking a repository allows you to make changes without affecting the original project."
-msgstr ""
-
 msgid "Forking in progress"
 msgstr ""
 
@@ -26879,9 +26876,6 @@ msgstr ""
 msgid "Select a label"
 msgstr ""
 
-msgid "Select a namespace to fork the project"
-msgstr ""
-
 msgid "Select a new namespace"
 msgstr ""
 

spec/frontend/pages/projects/forks/new/components/app_spec.js

 import { shallowMount } from '@vue/test-utils';
 import App from '~/pages/projects/forks/new/components/app.vue';
 
-jest.mock('~/flash');
-
 describe('App component', () => {
   let wrapper;
 
   const DEFAULT_PROPS = {
     forkIllustration: 'illustrations/project-create-new-sm.svg',
     endpoint: '/some/project-full-path/-/forks/new.json',
-    newGroupPath: 'some/groups/path',
     projectFullPath: '/some/project-full-path',
-    visibilityHelpPath: 'some/visibility/help/path',
     projectId: '10',
     projectName: 'Project Name',
     projectPath: 'project-name',

spec/frontend/pages/projects/forks/new/components/fork_form_spec.js

@@ -30,9 +30,7 @@ describe('ForkForm component', () => {
 
   const DEFAULT_PROPS = {
     endpoint: '/some/project-full-path/-/forks/new.json',
-    newGroupPath: 'some/groups/path',
     projectFullPath: '/some/project-full-path',
-    visibilityHelpPath: 'some/visibility/help/path',
     projectId: '10',
     projectName: 'Project Name',
     projectPath: 'project-name',
@@ -46,6 +44,10 @@ describe('ForkForm component', () => {
 
   const createComponent = (props = {}, data = {}) => {
     wrapper = shallowMount(ForkForm, {
+      provide: {
+        newGroupPath: 'some/groups/path',
+        visibilityHelpPath: 'some/visibility/help/path',
+      },
       propsData: {
         ...DEFAULT_PROPS,
         ...props,