Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
248cf393
Commit
248cf393
authored
Apr 14, 2021
by
Abdul Wadood
Committed by
Alper Akgun
Apr 14, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/services/security
parent
4936d09d
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
8 additions
and
3 deletions
+8
-3
.rubocop_manual_todo.yml
.rubocop_manual_todo.yml
+0
-3
ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-services-security.yml
...c-empty-lines-after-letitbe-ee-spec-services-security.yml
+5
-0
ee/spec/services/security/auto_fix_label_service_spec.rb
ee/spec/services/security/auto_fix_label_service_spec.rb
+1
-0
ee/spec/services/security/store_grouped_scans_service_spec.rb
...pec/services/security/store_grouped_scans_service_spec.rb
+1
-0
ee/spec/services/security/store_report_service_spec.rb
ee/spec/services/security/store_report_service_spec.rb
+1
-0
No files found.
.rubocop_manual_todo.yml
View file @
248cf393
...
...
@@ -597,9 +597,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
-
ee/spec/services/requirements_management/update_requirement_service_spec.rb
-
ee/spec/services/resource_access_tokens/create_service_spec.rb
-
ee/spec/services/resource_access_tokens/revoke_service_spec.rb
-
ee/spec/services/security/auto_fix_label_service_spec.rb
-
ee/spec/services/security/store_grouped_scans_service_spec.rb
-
ee/spec/services/security/store_report_service_spec.rb
-
ee/spec/services/status_page/publish_attachments_service_spec.rb
-
ee/spec/services/status_page/publish_details_service_spec.rb
-
ee/spec/services/status_page/publish_list_service_spec.rb
...
...
ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-services-security.yml
0 → 100644
View file @
248cf393
---
title
:
Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/services/security
merge_request
:
58323
author
:
Abdul Wadood @abdulwd
type
:
fixed
ee/spec/services/security/auto_fix_label_service_spec.rb
View file @
248cf393
...
...
@@ -8,6 +8,7 @@ RSpec.describe Security::AutoFixLabelService do
let_it_be
(
:project
)
{
create
(
:project
)
}
let_it_be
(
:bot
)
{
create
(
:user
,
:security_bot
)
}
let
(
:label_attributes
)
{
described_class
::
LABEL_PROPERTIES
}
let
(
:title
)
{
label_attributes
[
:title
]
}
let
(
:color
)
{
label_attributes
[
:color
]
}
...
...
ee/spec/services/security/store_grouped_scans_service_spec.rb
View file @
248cf393
...
...
@@ -74,6 +74,7 @@ RSpec.describe Security::StoreGroupedScansService do
let_it_be
(
:sast_artifact_1
)
{
create
(
:ee_ci_job_artifact
,
:sast
,
job:
create
(
:ee_ci_build
))
}
let_it_be
(
:sast_artifact_2
)
{
create
(
:ee_ci_job_artifact
,
:sast
,
job:
create
(
:ee_ci_build
))
}
let_it_be
(
:sast_artifact_3
)
{
create
(
:ee_ci_job_artifact
,
:sast
,
job:
create
(
:ee_ci_build
))
}
let
(
:scanner_1
)
{
instance_double
(
::
Gitlab
::
Ci
::
Reports
::
Security
::
Scanner
,
external_id:
'unknown'
)
}
let
(
:scanner_2
)
{
instance_double
(
::
Gitlab
::
Ci
::
Reports
::
Security
::
Scanner
,
external_id:
'bandit'
)
}
let
(
:scanner_3
)
{
instance_double
(
::
Gitlab
::
Ci
::
Reports
::
Security
::
Scanner
,
external_id:
'semgrep'
)
}
...
...
ee/spec/services/security/store_report_service_spec.rb
View file @
248cf393
...
...
@@ -4,6 +4,7 @@ require 'spec_helper'
RSpec
.
describe
Security
::
StoreReportService
,
'#execute'
do
let_it_be
(
:user
)
{
create
(
:user
)
}
let
(
:artifact
)
{
create
(
:ee_ci_job_artifact
,
trait
)
}
let
(
:report_type
)
{
artifact
.
file_type
}
let
(
:project
)
{
artifact
.
project
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment