Commit 27f85f86 authored by Ramya Authappan's avatar Ramya Authappan

Merge branch 'ml-remove-flag-from-code-owner-e2e-tests' into 'master'

Remove skip_web_ui_code_owner_validations flag from code owner e2e tests

Closes gitlab-org/quality/team-tasks#511

See merge request gitlab-org/gitlab!37373
parents 73d7243a ba2b282a
# frozen_string_literal: true # frozen_string_literal: true
module QA module QA
# These tests will fail unless the feature flag `skip_web_ui_code_owner_validations` is enabled. context 'Create' do
# That requirement is temporary. See https://gitlab.com/gitlab-org/gitlab/-/issues/217427
# When the flag is no longer needed:
# - the tests will no longer need to toggle it, and
# - the tests will not require admin access, and
# - the tests can be run in live environments
# Tracked in https://gitlab.com/gitlab-org/quality/team-tasks/-/issues/511
context 'Create', :requires_admin, :skip_live_env do
describe 'Codeowners' do describe 'Codeowners' do
before(:context) do
@feature_flag = 'skip_web_ui_code_owner_validations'
@feature_flag_enabled = Runtime::Feature.enabled?(@feature_flag)
Runtime::Feature.enable_and_verify(@feature_flag) unless @feature_flag_enabled
end
after(:context) do
Runtime::Feature.disable_and_verify(@feature_flag) unless @feature_flag_enabled
end
context 'when the project is in the root group' do context 'when the project is in the root group' do
let(:approver) { Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_1, Runtime::Env.gitlab_qa_password_1) } let(:approver) { Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_1, Runtime::Env.gitlab_qa_password_1) }
let(:root_group) { Resource::Sandbox.fabricate_via_api! } let(:root_group) { Resource::Sandbox.fabricate_via_api! }
......
# frozen_string_literal: true # frozen_string_literal: true
module QA module QA
# These tests will fail unless the feature flag `skip_web_ui_code_owner_validations` is enabled. context 'Create' do
# That requirement is temporary. See https://gitlab.com/gitlab-org/gitlab/-/issues/217427
# When the flag is no longer needed:
# - the tests will no longer need to toggle it, and
# - the tests will not require admin access, and
# - the tests can be run in live environments
# Tracked in https://gitlab.com/gitlab-org/quality/team-tasks/-/issues/511
context 'Create', :requires_admin, :skip_live_env do
describe 'Codeowners' do describe 'Codeowners' do
before(:context) do
@feature_flag = 'skip_web_ui_code_owner_validations'
@feature_flag_enabled = Runtime::Feature.enabled?(@feature_flag)
Runtime::Feature.enable_and_verify(@feature_flag) unless @feature_flag_enabled
end
after(:context) do
Runtime::Feature.disable_and_verify(@feature_flag) unless @feature_flag_enabled
end
context 'when the project is in a subgroup' do context 'when the project is in a subgroup' do
let(:approver) { Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_1, Runtime::Env.gitlab_qa_password_1) } let(:approver) { Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_1, Runtime::Env.gitlab_qa_password_1) }
let(:project) do let(:project) do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment