Commit 286fb262 authored by Thong Kuah's avatar Thong Kuah

Rephrase "Nit:" as small, non-mandatory

parent c6a4124e
...@@ -294,9 +294,8 @@ experience, refactors the existing code). Then: ...@@ -294,9 +294,8 @@ experience, refactors the existing code). Then:
- Seek to understand the author's perspective. - Seek to understand the author's perspective.
- If you don't understand a piece of code, _say so_. There's a good chance - If you don't understand a piece of code, _say so_. There's a good chance
someone else would be confused by it as well. someone else would be confused by it as well.
- If you have an improvement you wish to suggest based on personal - Do prefix your comment with "Nit:" if you have a small, non-mandatory
preference, do prefix your comment with "Nit:" to let the author know improvement you wish to suggest.
it is not a mandatory improvement.
- After a round of line notes, it can be helpful to post a summary note such as - After a round of line notes, it can be helpful to post a summary note such as
"LGTM :thumbsup:", or "Just a couple things to address." "LGTM :thumbsup:", or "Just a couple things to address."
- Assign the merge request to the author if changes are required following your - Assign the merge request to the author if changes are required following your
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment