Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
286fb262
Commit
286fb262
authored
Sep 16, 2019
by
Thong Kuah
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Rephrase "Nit:" as small, non-mandatory
parent
c6a4124e
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
3 deletions
+2
-3
doc/development/code_review.md
doc/development/code_review.md
+2
-3
No files found.
doc/development/code_review.md
View file @
286fb262
...
@@ -294,9 +294,8 @@ experience, refactors the existing code). Then:
...
@@ -294,9 +294,8 @@ experience, refactors the existing code). Then:
-
Seek to understand the author's perspective.
-
Seek to understand the author's perspective.
-
If you don't understand a piece of code, _say so_. There's a good chance
-
If you don't understand a piece of code, _say so_. There's a good chance
someone else would be confused by it as well.
someone else would be confused by it as well.
-
If you have an improvement you wish to suggest based on personal
-
Do prefix your comment with "Nit:" if you have a small, non-mandatory
preference, do prefix your comment with "Nit:" to let the author know
improvement you wish to suggest.
it is not a mandatory improvement.
-
After a round of line notes, it can be helpful to post a summary note such as
-
After a round of line notes, it can be helpful to post a summary note such as
"LGTM :thumbsup:", or "Just a couple things to address."
"LGTM :thumbsup:", or "Just a couple things to address."
-
Assign the merge request to the author if changes are required following your
-
Assign the merge request to the author if changes are required following your
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment