Commit 297b424f authored by Lin Jen-Shin's avatar Lin Jen-Shin

Resolve conflicts

parent 6cce656e
...@@ -2,11 +2,7 @@ class AutocompleteController < ApplicationController ...@@ -2,11 +2,7 @@ class AutocompleteController < ApplicationController
AWARD_EMOJI_MAX = 100 AWARD_EMOJI_MAX = 100
skip_before_action :authenticate_user!, only: [:users, :award_emojis] skip_before_action :authenticate_user!, only: [:users, :award_emojis]
<<<<<<< HEAD
before_action :load_project, only: [:users, :project_groups]
=======
before_action :load_project, only: [:users] before_action :load_project, only: [:users]
>>>>>>> upstream/master
before_action :find_users, only: [:users] before_action :find_users, only: [:users]
def users def users
...@@ -63,11 +59,7 @@ class AutocompleteController < ApplicationController ...@@ -63,11 +59,7 @@ class AutocompleteController < ApplicationController
.limit(AWARD_EMOJI_MAX) .limit(AWARD_EMOJI_MAX)
.where(user: current_user) .where(user: current_user)
.group(:name) .group(:name)
<<<<<<< HEAD
.order(count: :desc, name: :asc)
=======
.order('count_all DESC, name ASC') .order('count_all DESC, name ASC')
>>>>>>> upstream/master
.count .count
# Transform from hash to array to guarantee json order # Transform from hash to array to guarantee json order
......
...@@ -366,7 +366,6 @@ class IssuableFinder ...@@ -366,7 +366,6 @@ class IssuableFinder
items items
end end
<<<<<<< HEAD
def by_weight(items) def by_weight(items)
return items unless weights? return items unless weights?
...@@ -392,8 +391,6 @@ class IssuableFinder ...@@ -392,8 +391,6 @@ class IssuableFinder
params[:weight] == Issue::WEIGHT_ANY params[:weight] == Issue::WEIGHT_ANY
end end
=======
>>>>>>> upstream/master
def by_my_reaction_emoji(items) def by_my_reaction_emoji(items)
if params[:my_reaction_emoji].present? && current_user if params[:my_reaction_emoji].present? && current_user
items = items.awarded(current_user, params[:my_reaction_emoji]) items = items.awarded(current_user, params[:my_reaction_emoji])
......
...@@ -1117,13 +1117,8 @@ class Repository ...@@ -1117,13 +1117,8 @@ class Repository
false false
end end
<<<<<<< HEAD
def fetch_remote(remote, forced: false, ssh_auth: nil, no_tags: false) def fetch_remote(remote, forced: false, ssh_auth: nil, no_tags: false)
gitlab_shell.fetch_remote(repository_storage_path, disk_path, remote, ssh_auth: ssh_auth, forced: forced, no_tags: no_tags) gitlab_shell.fetch_remote(raw_repository, remote, ssh_auth: ssh_auth, forced: forced, no_tags: no_tags)
=======
def fetch_remote(remote, forced: false, no_tags: false)
gitlab_shell.fetch_remote(raw_repository, remote, forced: forced, no_tags: no_tags)
>>>>>>> upstream/master
end end
def fetch_ref(source_path, source_ref, target_ref) def fetch_ref(source_path, source_ref, target_ref)
......
...@@ -47,11 +47,7 @@ ...@@ -47,11 +47,7 @@
%span %span
ConvDev Index ConvDev Index
<<<<<<< HEAD
= nav_link(controller: %w(conversational_development_index system_info background_jobs logs health_check requests_profiles audit_logs)) do = nav_link(controller: %w(conversational_development_index system_info background_jobs logs health_check requests_profiles audit_logs)) do
=======
= nav_link(controller: %w(conversational_development_index system_info background_jobs logs health_check requests_profiles)) do
>>>>>>> upstream/master
= sidebar_link admin_conversational_development_index_path, title: _('Monitoring') do = sidebar_link admin_conversational_development_index_path, title: _('Monitoring') do
.nav-icon-container .nav-icon-container
= custom_icon('monitoring') = custom_icon('monitoring')
......
...@@ -7,11 +7,7 @@ ...@@ -7,11 +7,7 @@
.sidebar-context-title .sidebar-context-title
= @group.name = @group.name
%ul.sidebar-top-level-items %ul.sidebar-top-level-items
<<<<<<< HEAD
= nav_link(path: ['groups#show', 'groups#activity', 'groups#subgroups', 'analytics#show'], html_options: { class: 'home' }) do = nav_link(path: ['groups#show', 'groups#activity', 'groups#subgroups', 'analytics#show'], html_options: { class: 'home' }) do
=======
= nav_link(path: ['groups#show', 'groups#activity', 'groups#subgroups'], html_options: { class: 'home' }) do
>>>>>>> upstream/master
= sidebar_link group_path(@group), title: _('Group overview') do = sidebar_link group_path(@group), title: _('Group overview') do
.nav-icon-container .nav-icon-container
= custom_icon('project') = custom_icon('project')
...@@ -75,11 +71,7 @@ ...@@ -75,11 +71,7 @@
%span.nav-item-name %span.nav-item-name
Members Members
- if current_user && can?(current_user, :admin_group, @group) - if current_user && can?(current_user, :admin_group, @group)
<<<<<<< HEAD
= nav_link(path: %w[groups#projects groups#edit ci_cd#show ldap_group_links#index hooks#index audit_events#index pipeline_quota#index]) do = nav_link(path: %w[groups#projects groups#edit ci_cd#show ldap_group_links#index hooks#index audit_events#index pipeline_quota#index]) do
=======
= nav_link(path: %w[groups#projects groups#edit ci_cd#show]) do
>>>>>>> upstream/master
= sidebar_link edit_group_path(@group), title: _('Settings') do = sidebar_link edit_group_path(@group), title: _('Settings') do
.nav-icon-container .nav-icon-container
= custom_icon('settings') = custom_icon('settings')
......
...@@ -104,7 +104,6 @@ ...@@ -104,7 +104,6 @@
%gl-emoji %gl-emoji
%span.js-data-value.prepend-left-10 %span.js-data-value.prepend-left-10
{{name}} {{name}}
<<<<<<< HEAD
- if type == :issues || type == :boards || type == :boards_modal - if type == :issues || type == :boards || type == :boards_modal
#js-dropdown-weight.filtered-search-input-dropdown-menu.dropdown-menu #js-dropdown-weight.filtered-search-input-dropdown-menu.dropdown-menu
...@@ -121,8 +120,6 @@ ...@@ -121,8 +120,6 @@
%li.filter-dropdown-item{ 'data-value' => "#{weight}" } %li.filter-dropdown-item{ 'data-value' => "#{weight}" }
%button.btn.btn-link= weight %button.btn.btn-link= weight
=======
>>>>>>> upstream/master
%button.clear-search.hidden{ type: 'button' } %button.clear-search.hidden{ type: 'button' }
= icon('times') = icon('times')
.filter-dropdown-container .filter-dropdown-container
......
...@@ -36,10 +36,7 @@ Rails.application.routes.draw do ...@@ -36,10 +36,7 @@ Rails.application.routes.draw do
get '/autocomplete/users/:id' => 'autocomplete#user' get '/autocomplete/users/:id' => 'autocomplete#user'
get '/autocomplete/projects' => 'autocomplete#projects' get '/autocomplete/projects' => 'autocomplete#projects'
get '/autocomplete/award_emojis' => 'autocomplete#award_emojis' get '/autocomplete/award_emojis' => 'autocomplete#award_emojis'
<<<<<<< HEAD
get '/autocomplete/project_groups' => 'autocomplete#project_groups' get '/autocomplete/project_groups' => 'autocomplete#project_groups'
=======
>>>>>>> upstream/master
# Search # Search
get 'search' => 'search#show' get 'search' => 'search#show'
......
...@@ -83,14 +83,11 @@ Manage your [repositories](user/project/repository/index.md) from the UI (user i ...@@ -83,14 +83,11 @@ Manage your [repositories](user/project/repository/index.md) from the UI (user i
- [Create a branch](user/project/repository/web_editor.md#create-a-new-branch) - [Create a branch](user/project/repository/web_editor.md#create-a-new-branch)
- [Protected branches](user/project/protected_branches.md#protected-branches) - [Protected branches](user/project/protected_branches.md#protected-branches)
- [Delete merged branches](user/project/repository/branches/index.md#delete-merged-branches) - [Delete merged branches](user/project/repository/branches/index.md#delete-merged-branches)
<<<<<<< HEAD - Commits
- [Signing commits](user/project/repository/gpg_signed_commits/index.md): use GPG to sign your commits.
- **(EES/EEP)** [Repository Mirroring](workflow/repository_mirroring.md) - **(EES/EEP)** [Repository Mirroring](workflow/repository_mirroring.md)
- **(EES/EEP)** [Push rules](push_rules/push_rules.md): Additional control over pushes to your project. - **(EES/EEP)** [Push rules](push_rules/push_rules.md): Additional control over pushes to your project.
- **(EEP)** [File Locking](user/project/file_lock.md): Lock a file to avoid merge conflicts. - **(EEP)** [File Locking](user/project/file_lock.md): Lock a file to avoid merge conflicts.
=======
- Commits
- [Signing commits](user/project/repository/gpg_signed_commits/index.md): use GPG to sign your commits.
>>>>>>> upstream/master
### Issues and Merge Requests (MRs) ### Issues and Merge Requests (MRs)
......
...@@ -101,10 +101,8 @@ Example response: ...@@ -101,10 +101,8 @@ Example response:
"user_notes_count": 1, "user_notes_count": 1,
"due_date": "2016-07-22", "due_date": "2016-07-22",
"web_url": "http://example.com/example/example/issues/6", "web_url": "http://example.com/example/example/issues/6",
<<<<<<< HEAD
"confidential": false, "confidential": false,
"weight": null "weight": null,
=======
"time_stats": { "time_stats": {
"time_estimate": 0, "time_estimate": 0,
"total_time_spent": 0, "total_time_spent": 0,
...@@ -112,7 +110,6 @@ Example response: ...@@ -112,7 +110,6 @@ Example response:
"human_total_time_spent": null "human_total_time_spent": null
}, },
"confidential": false "confidential": false
>>>>>>> upstream/master
} }
] ]
``` ```
...@@ -209,10 +206,8 @@ Example response: ...@@ -209,10 +206,8 @@ Example response:
"user_notes_count": 1, "user_notes_count": 1,
"due_date": null, "due_date": null,
"web_url": "http://example.com/example/example/issues/1", "web_url": "http://example.com/example/example/issues/1",
<<<<<<< HEAD
"confidential": false, "confidential": false,
"weight": null "weight": null,
=======
"time_stats": { "time_stats": {
"time_estimate": 0, "time_estimate": 0,
"total_time_spent": 0, "total_time_spent": 0,
...@@ -220,7 +215,6 @@ Example response: ...@@ -220,7 +215,6 @@ Example response:
"human_total_time_spent": null "human_total_time_spent": null
}, },
"confidential": false "confidential": false
>>>>>>> upstream/master
} }
] ]
``` ```
...@@ -318,10 +312,8 @@ Example response: ...@@ -318,10 +312,8 @@ Example response:
"user_notes_count": 1, "user_notes_count": 1,
"due_date": "2016-07-22", "due_date": "2016-07-22",
"web_url": "http://example.com/example/example/issues/1", "web_url": "http://example.com/example/example/issues/1",
<<<<<<< HEAD
"confidential": false, "confidential": false,
"weight": null "weight": null,
=======
"time_stats": { "time_stats": {
"time_estimate": 0, "time_estimate": 0,
"total_time_spent": 0, "total_time_spent": 0,
...@@ -329,7 +321,6 @@ Example response: ...@@ -329,7 +321,6 @@ Example response:
"human_total_time_spent": null "human_total_time_spent": null
}, },
"confidential": false "confidential": false
>>>>>>> upstream/master
} }
] ]
``` ```
......
...@@ -188,10 +188,7 @@ Parameters: ...@@ -188,10 +188,7 @@ Parameters:
"approvals_before_merge": null "approvals_before_merge": null
"should_remove_source_branch": true, "should_remove_source_branch": true,
"force_remove_source_branch": false, "force_remove_source_branch": false,
<<<<<<< HEAD
"squash": false, "squash": false,
"web_url": "http://example.com/example/example/merge_requests/1"
=======
"web_url": "http://example.com/example/example/merge_requests/1", "web_url": "http://example.com/example/example/merge_requests/1",
"time_stats": { "time_stats": {
"time_estimate": 0, "time_estimate": 0,
...@@ -199,7 +196,6 @@ Parameters: ...@@ -199,7 +196,6 @@ Parameters:
"human_time_estimate": null, "human_time_estimate": null,
"human_total_time_spent": null "human_total_time_spent": null
} }
>>>>>>> upstream/master
} }
] ]
``` ```
...@@ -269,10 +265,7 @@ Parameters: ...@@ -269,10 +265,7 @@ Parameters:
"approvals_before_merge": null "approvals_before_merge": null
"should_remove_source_branch": true, "should_remove_source_branch": true,
"force_remove_source_branch": false, "force_remove_source_branch": false,
<<<<<<< HEAD
"squash": false, "squash": false,
"web_url": "http://example.com/example/example/merge_requests/1"
=======
"web_url": "http://example.com/example/example/merge_requests/1", "web_url": "http://example.com/example/example/merge_requests/1",
"time_stats": { "time_stats": {
"time_estimate": 0, "time_estimate": 0,
...@@ -280,7 +273,6 @@ Parameters: ...@@ -280,7 +273,6 @@ Parameters:
"human_time_estimate": null, "human_time_estimate": null,
"human_total_time_spent": null "human_total_time_spent": null
} }
>>>>>>> upstream/master
} }
``` ```
...@@ -492,10 +484,7 @@ order for it to take effect: ...@@ -492,10 +484,7 @@ order for it to take effect:
"approvals_before_merge": null "approvals_before_merge": null
"should_remove_source_branch": true, "should_remove_source_branch": true,
"force_remove_source_branch": false, "force_remove_source_branch": false,
<<<<<<< HEAD
"squash": false, "squash": false,
"web_url": "http://example.com/example/example/merge_requests/1"
=======
"web_url": "http://example.com/example/example/merge_requests/1", "web_url": "http://example.com/example/example/merge_requests/1",
"time_stats": { "time_stats": {
"time_estimate": 0, "time_estimate": 0,
...@@ -503,7 +492,6 @@ order for it to take effect: ...@@ -503,7 +492,6 @@ order for it to take effect:
"human_time_estimate": null, "human_time_estimate": null,
"human_total_time_spent": null "human_total_time_spent": null
} }
>>>>>>> upstream/master
} }
``` ```
...@@ -584,10 +572,7 @@ Must include at least one non-required attribute from above. ...@@ -584,10 +572,7 @@ Must include at least one non-required attribute from above.
"approvals_before_merge": null "approvals_before_merge": null
"should_remove_source_branch": true, "should_remove_source_branch": true,
"force_remove_source_branch": false, "force_remove_source_branch": false,
<<<<<<< HEAD
"squash": false, "squash": false,
"web_url": "http://example.com/example/example/merge_requests/1"
=======
"web_url": "http://example.com/example/example/merge_requests/1", "web_url": "http://example.com/example/example/merge_requests/1",
"time_stats": { "time_stats": {
"time_estimate": 0, "time_estimate": 0,
...@@ -595,7 +580,6 @@ Must include at least one non-required attribute from above. ...@@ -595,7 +580,6 @@ Must include at least one non-required attribute from above.
"human_time_estimate": null, "human_time_estimate": null,
"human_total_time_spent": null "human_total_time_spent": null
} }
>>>>>>> upstream/master
} }
``` ```
...@@ -694,10 +678,7 @@ Parameters: ...@@ -694,10 +678,7 @@ Parameters:
"approvals_before_merge": null "approvals_before_merge": null
"should_remove_source_branch": true, "should_remove_source_branch": true,
"force_remove_source_branch": false, "force_remove_source_branch": false,
<<<<<<< HEAD
"squash": false, "squash": false,
"web_url": "http://example.com/example/example/merge_requests/1"
=======
"web_url": "http://example.com/example/example/merge_requests/1", "web_url": "http://example.com/example/example/merge_requests/1",
"time_stats": { "time_stats": {
"time_estimate": 0, "time_estimate": 0,
...@@ -705,7 +686,6 @@ Parameters: ...@@ -705,7 +686,6 @@ Parameters:
"human_time_estimate": null, "human_time_estimate": null,
"human_total_time_spent": null "human_total_time_spent": null
} }
>>>>>>> upstream/master
} }
``` ```
...@@ -902,10 +882,7 @@ Parameters: ...@@ -902,10 +882,7 @@ Parameters:
"approvals_before_merge": null "approvals_before_merge": null
"should_remove_source_branch": true, "should_remove_source_branch": true,
"force_remove_source_branch": false, "force_remove_source_branch": false,
<<<<<<< HEAD
"squash": false, "squash": false,
"web_url": "http://example.com/example/example/merge_requests/1"
=======
"web_url": "http://example.com/example/example/merge_requests/1", "web_url": "http://example.com/example/example/merge_requests/1",
"time_stats": { "time_stats": {
"time_estimate": 0, "time_estimate": 0,
...@@ -913,7 +890,6 @@ Parameters: ...@@ -913,7 +890,6 @@ Parameters:
"human_time_estimate": null, "human_time_estimate": null,
"human_total_time_spent": null "human_total_time_spent": null
} }
>>>>>>> upstream/master
} }
``` ```
......
...@@ -130,11 +130,7 @@ module API ...@@ -130,11 +130,7 @@ module API
commit = user_project.repository.commit(branch.dereferenced_target) commit = user_project.repository.commit(branch.dereferenced_target)
<<<<<<< HEAD
destroy_conditionally!(commit, last_update_field: :authored_date) do
=======
destroy_conditionally!(commit, last_updated: commit.authored_date) do destroy_conditionally!(commit, last_updated: commit.authored_date) do
>>>>>>> upstream/master
result = DeleteBranchService.new(user_project, current_user) result = DeleteBranchService.new(user_project, current_user)
.execute(params[:branch]) .execute(params[:branch])
......
...@@ -21,15 +21,10 @@ module API ...@@ -21,15 +21,10 @@ module API
end end
end end
<<<<<<< HEAD
def destroy_conditionally!(resource, last_update_field: :updated_at)
check_unmodified_since!(resource.public_send(last_update_field))
=======
def destroy_conditionally!(resource, last_updated: nil) def destroy_conditionally!(resource, last_updated: nil)
last_updated ||= resource.updated_at last_updated ||= resource.updated_at
check_unmodified_since!(last_updated) check_unmodified_since!(last_updated)
>>>>>>> upstream/master
status 204 status 204
if block_given? if block_given?
......
...@@ -70,11 +70,7 @@ module API ...@@ -70,11 +70,7 @@ module API
commit = user_project.repository.commit(tag.dereferenced_target) commit = user_project.repository.commit(tag.dereferenced_target)
<<<<<<< HEAD
destroy_conditionally!(commit, last_update_field: :authored_date) do
=======
destroy_conditionally!(commit, last_updated: commit.authored_date) do destroy_conditionally!(commit, last_updated: commit.authored_date) do
>>>>>>> upstream/master
result = ::Tags::DestroyService.new(user_project, current_user) result = ::Tags::DestroyService.new(user_project, current_user)
.execute(params[:tag_name]) .execute(params[:tag_name])
......
...@@ -100,11 +100,7 @@ describe 'Search bar', js: true do ...@@ -100,11 +100,7 @@ describe 'Search bar', js: true do
find('.filtered-search-box .clear-search').click find('.filtered-search-box .clear-search').click
filtered_search.click filtered_search.click
<<<<<<< HEAD
expect(find('#js-dropdown-hint')).to have_selector('.filter-dropdown .filter-dropdown-item', count: 6)
=======
expect(find('#js-dropdown-hint')).to have_selector('.filter-dropdown .filter-dropdown-item', count: 5) expect(find('#js-dropdown-hint')).to have_selector('.filter-dropdown .filter-dropdown-item', count: 5)
>>>>>>> upstream/master
expect(get_left_style(find('#js-dropdown-hint')['style'])).to eq(hint_offset) expect(get_left_style(find('#js-dropdown-hint')['style'])).to eq(hint_offset)
end end
end end
......
...@@ -73,17 +73,14 @@ ...@@ -73,17 +73,14 @@
"should_remove_source_branch": { "type": ["boolean", "null"] }, "should_remove_source_branch": { "type": ["boolean", "null"] },
"force_remove_source_branch": { "type": ["boolean", "null"] }, "force_remove_source_branch": { "type": ["boolean", "null"] },
"web_url": { "type": "uri" }, "web_url": { "type": "uri" },
<<<<<<< HEAD
"approvals_before_merge": { "type": ["integer", "null"] }, "approvals_before_merge": { "type": ["integer", "null"] },
"squash": { "type": "boolean" } "squash": { "type": "boolean" },
=======
"time_stats": { "time_stats": {
"time_estimate": { "type": "integer" }, "time_estimate": { "type": "integer" },
"total_time_spent": { "type": "integer" }, "total_time_spent": { "type": "integer" },
"human_time_estimate": { "type": ["string", "null"] }, "human_time_estimate": { "type": ["string", "null"] },
"human_total_time_spent": { "type": ["string", "null"] } "human_total_time_spent": { "type": ["string", "null"] }
} }
>>>>>>> upstream/master
}, },
"required": [ "required": [
"id", "iid", "project_id", "title", "description", "id", "iid", "project_id", "title", "description",
......
...@@ -1257,7 +1257,6 @@ describe API::Projects do ...@@ -1257,7 +1257,6 @@ describe API::Projects do
before do before do
create(:project_group_link, group: group, project: project) create(:project_group_link, group: group, project: project)
end end
<<<<<<< HEAD
it 'returns 204 when deleting a group share' do it 'returns 204 when deleting a group share' do
delete api("/projects/#{project.id}/share/#{group.id}", user) delete api("/projects/#{project.id}/share/#{group.id}", user)
...@@ -1266,8 +1265,6 @@ describe API::Projects do ...@@ -1266,8 +1265,6 @@ describe API::Projects do
expect(project.project_group_links).to be_empty expect(project.project_group_links).to be_empty
end end
=======
it 'returns 204 when deleting a group share' do it 'returns 204 when deleting a group share' do
delete api("/projects/#{project.id}/share/#{group.id}", user) delete api("/projects/#{project.id}/share/#{group.id}", user)
...@@ -1275,7 +1272,6 @@ describe API::Projects do ...@@ -1275,7 +1272,6 @@ describe API::Projects do
expect(project.project_group_links).to be_empty expect(project.project_group_links).to be_empty
end end
>>>>>>> upstream/master
it_behaves_like '412 response' do it_behaves_like '412 response' do
let(:request) { api("/projects/#{project.id}/share/#{group.id}", user) } let(:request) { api("/projects/#{project.id}/share/#{group.id}", user) }
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment