Commit 2c45a73c authored by Phil Hughes's avatar Phil Hughes

Fixed label select toggle not updating correctly

Closes #26119
parent 79373bdc
...@@ -336,7 +336,11 @@ ...@@ -336,7 +336,11 @@
.removeClass('is-active') .removeClass('is-active')
} }
if ($dropdown.hasClass('js-filter-bulk-update') || $dropdown.hasClass('js-issuable-form-dropdown')) { if ($dropdown.hasClass('js-issuable-form-dropdown')) {
return;
}
if ($dropdown.hasClass('js-filter-bulk-update')) {
_this.enableBulkLabelDropdown(); _this.enableBulkLabelDropdown();
_this.setDropdownData($dropdown, isMarking, this.id(label)); _this.setDropdownData($dropdown, isMarking, this.id(label));
return; return;
......
---
title: Fixed label dropdown toggle text not correctly updating
merge_request:
author:
...@@ -68,6 +68,22 @@ describe 'New/edit issue', feature: true, js: true do ...@@ -68,6 +68,22 @@ describe 'New/edit issue', feature: true, js: true do
end end
end end
end end
it 'correctly updates the dropdown toggle when removing a label' do
click_button 'Labels'
page.within '.dropdown-menu-labels' do
click_link label.title
end
expect(find('.js-label-select')).to have_content(label.title)
page.within '.dropdown-menu-labels' do
click_link label.title
end
expect(find('.js-label-select')).to have_content('Labels')
end
end end
context 'edit issue' do context 'edit issue' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment