Commit 2c5a449f authored by Sean McGivern's avatar Sean McGivern

ChatNotificationWorker has external dependencies

parent 5a0c073c
...@@ -866,8 +866,8 @@ ...@@ -866,8 +866,8 @@
:idempotent: :idempotent:
- :name: chat_notification - :name: chat_notification
:feature_category: :chatops :feature_category: :chatops
:has_external_dependencies: :has_external_dependencies: true
:urgency: :high :urgency: :low
:resource_boundary: :unknown :resource_boundary: :unknown
:weight: 2 :weight: 2
:idempotent: :idempotent:
......
...@@ -7,13 +7,9 @@ class ChatNotificationWorker # rubocop:disable Scalability/IdempotentWorker ...@@ -7,13 +7,9 @@ class ChatNotificationWorker # rubocop:disable Scalability/IdempotentWorker
sidekiq_options retry: false sidekiq_options retry: false
feature_category :chatops feature_category :chatops
urgency :high urgency :low # Can't be high as it has external dependencies
weight 2 weight 2
worker_has_external_dependencies!
# TODO: break this into multiple jobs
# as the `responder` uses external dependencies
# See https://gitlab.com/gitlab-com/gl-infra/scalability/issues/34
# worker_has_external_dependencies!
RESCHEDULE_INTERVAL = 2.seconds RESCHEDULE_INTERVAL = 2.seconds
RESCHEDULE_TIMEOUT = 5.minutes RESCHEDULE_TIMEOUT = 5.minutes
......
...@@ -157,7 +157,7 @@ describe Gitlab::SidekiqCluster::CLI do ...@@ -157,7 +157,7 @@ describe Gitlab::SidekiqCluster::CLI do
.with([['chat_notification'], ['project_export']], default_options) .with([['chat_notification'], ['project_export']], default_options)
.and_return([]) .and_return([])
cli.run(%w(--experimental-queue-selector feature_category=chatops&urgency=high resource_boundary=memory&feature_category=importers)) cli.run(%w(--experimental-queue-selector feature_category=chatops&has_external_dependencies=true resource_boundary=memory&feature_category=importers))
end end
it 'allows the special * selector' do it 'allows the special * selector' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment