Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
2d6d5621
Commit
2d6d5621
authored
Jul 14, 2020
by
Savas Vedova
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Do not render export button when uninitialized
parent
828b1681
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
13 additions
and
1 deletion
+13
-1
ee/app/assets/javascripts/security_dashboard/components/first_class_instance_security_dashboard.vue
...rd/components/first_class_instance_security_dashboard.vue
+4
-1
ee/changelogs/unreleased/228891-hide-csv-export-button-when-unconfigured.yml
...eased/228891-hide-csv-export-button-when-unconfigured.yml
+5
-0
ee/spec/frontend/security_dashboard/components/first_class_instance_security_dashboard_spec.js
...omponents/first_class_instance_security_dashboard_spec.js
+4
-0
No files found.
ee/app/assets/javascripts/security_dashboard/components/first_class_instance_security_dashboard.vue
View file @
2d6d5621
...
@@ -101,7 +101,10 @@ export default {
...
@@ -101,7 +101,10 @@ export default {
<template
#header
>
<template
#header
>
<header
class=
"page-title-holder flex-fill d-flex align-items-center"
>
<header
class=
"page-title-holder flex-fill d-flex align-items-center"
>
<h2
class=
"page-title flex-grow"
>
{{
s__
(
'
SecurityReports|Security Dashboard
'
)
}}
</h2>
<h2
class=
"page-title flex-grow"
>
{{
s__
(
'
SecurityReports|Security Dashboard
'
)
}}
</h2>
<csv-export-button
:vulnerabilities-export-endpoint=
"vulnerabilitiesExportEndpoint"
/>
<csv-export-button
v-if=
"!shouldShowEmptyState"
:vulnerabilities-export-endpoint=
"vulnerabilitiesExportEndpoint"
/>
<gl-button
<gl-button
class=
"page-title-controls ml-2"
class=
"page-title-controls ml-2"
:variant=
"toggleButtonProps.variant"
:variant=
"toggleButtonProps.variant"
...
...
ee/changelogs/unreleased/228891-hide-csv-export-button-when-unconfigured.yml
0 → 100644
View file @
2d6d5621
---
title
:
Do not render export button when instance level security dashbaord is uninitialized
merge_request
:
36843
author
:
type
:
fixed
ee/spec/frontend/security_dashboard/components/first_class_instance_security_dashboard_spec.js
View file @
2d6d5621
...
@@ -108,6 +108,10 @@ describe('First Class Instance Dashboard Component', () => {
...
@@ -108,6 +108,10 @@ describe('First Class Instance Dashboard Component', () => {
expect
(
findEmptyState
().
props
()).
toEqual
({});
expect
(
findEmptyState
().
props
()).
toEqual
({});
});
});
it
(
'
does not render the export button
'
,
()
=>
{
expect
(
findCsvExportButton
().
exists
()).
toBe
(
false
);
});
it
(
'
does not render the vulnerability list
'
,
()
=>
{
it
(
'
does not render the vulnerability list
'
,
()
=>
{
expect
(
findInstanceVulnerabilities
().
exists
()).
toBe
(
false
);
expect
(
findInstanceVulnerabilities
().
exists
()).
toBe
(
false
);
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment