Commit 2f8d34fb authored by Rémy Coutable's avatar Rémy Coutable

Merge branch '257888-Improve-Runner-Breadcrumb-in-Admin-Section' into 'master'

Replace Runner Page Title with Runner’s Hash

See merge request gitlab-org/gitlab!44854
parents 0d8887b2 cdb3ac7d
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
%span.runner-state.runner-state-specific %span.runner-state.runner-state-specific
Specific Specific
- page_title _("Runners") - page_title @runner.short_sha
- add_to_breadcrumbs _("Runners"), admin_runners_path - add_to_breadcrumbs _("Runners"), admin_runners_path
- breadcrumb_title "##{@runner.id}" - breadcrumb_title "##{@runner.id}"
......
---
title: Replace Runner Page Title with Runner’s Hash
merge_request: 44854
author: Kev @KevSlashNull
type: changed
...@@ -282,6 +282,12 @@ RSpec.describe "Admin Runners" do ...@@ -282,6 +282,12 @@ RSpec.describe "Admin Runners" do
visit admin_runner_path(runner) visit admin_runner_path(runner)
end end
describe 'runner page breadcrumbs' do
it 'contains the current runner’s short sha' do
expect(page.find('h2')).to have_content(runner.short_sha)
end
end
describe 'projects' do describe 'projects' do
it 'contains project names' do it 'contains project names' do
expect(page).to have_content(@project1.full_name) expect(page).to have_content(@project1.full_name)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment