Commit 2fbdc529 authored by Shubham Kumar's avatar Shubham Kumar

Resolves rubocop offense Style/RedundantBegin

Fixes auto correct rubocop offenses
parent c765eb69
...@@ -847,13 +847,6 @@ Style/RaiseArgs: ...@@ -847,13 +847,6 @@ Style/RaiseArgs:
Enabled: false Enabled: false
EnforcedStyle: exploded EnforcedStyle: exploded
# Offense count: 2
# Cop supports --auto-correct.
Style/RedundantBegin:
Exclude:
- 'app/services/clusters/applications/check_installation_progress_service.rb'
- 'lib/gitlab/database/postgres_hll/batch_distinct_counter.rb'
# Offense count: 26 # Offense count: 26
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: SafeForConstants. # Configuration parameters: SafeForConstants.
......
...@@ -19,9 +19,9 @@ module Clusters ...@@ -19,9 +19,9 @@ module Clusters
def check_timeout def check_timeout
if timed_out? if timed_out?
begin
app.make_errored!("Operation timed out. Check pod logs for #{pod_name} for more details.") app.make_errored!("Operation timed out. Check pod logs for #{pod_name} for more details.")
end
else else
ClusterWaitForAppInstallationWorker.perform_in( ClusterWaitForAppInstallationWorker.perform_in(
ClusterWaitForAppInstallationWorker::INTERVAL, app.name, app.id) ClusterWaitForAppInstallationWorker::INTERVAL, app.name, app.id)
......
---
title: Resolves offenses Style/RedundantBegin
merge_request:
author: Shubham Kumar (@imskr)
type: fixed
...@@ -69,10 +69,10 @@ module Gitlab ...@@ -69,10 +69,10 @@ module Gitlab
hll_buckets = Buckets.new hll_buckets = Buckets.new
while batch_start <= finish while batch_start <= finish
begin
hll_buckets.merge_hash!(hll_buckets_for_batch(batch_start, batch_start + batch_size)) hll_buckets.merge_hash!(hll_buckets_for_batch(batch_start, batch_start + batch_size))
batch_start += batch_size batch_start += batch_size
end
sleep(SLEEP_TIME_IN_SECONDS) sleep(SLEEP_TIME_IN_SECONDS)
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment