Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
31d451bb
Commit
31d451bb
authored
Feb 10, 2022
by
Matthias Kaeppler
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove track_application_boot_time FF
Changelog: other
parent
b02d768f
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
2 additions
and
24 deletions
+2
-24
config/feature_flags/development/track_application_boot_time.yml
...feature_flags/development/track_application_boot_time.yml
+0
-8
lib/gitlab/metrics/boot_time_tracker.rb
lib/gitlab/metrics/boot_time_tracker.rb
+1
-1
spec/lib/gitlab/metrics/boot_time_tracker_spec.rb
spec/lib/gitlab/metrics/boot_time_tracker_spec.rb
+1
-15
No files found.
config/feature_flags/development/track_application_boot_time.yml
deleted
100644 → 0
View file @
b02d768f
---
name
:
track_application_boot_time
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/79139
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/351769
milestone
:
'
14.8'
type
:
development
group
:
group::memory
default_enabled
:
true
lib/gitlab/metrics/boot_time_tracker.rb
View file @
31d451bb
...
...
@@ -15,7 +15,7 @@ module Gitlab
return
if
@startup_time
runtime
=
Gitlab
::
Runtime
.
safe_identify
return
unless
SUPPORTED_RUNTIMES
.
include?
(
runtime
)
&&
Feature
.
enabled?
(
:track_application_boot_time
,
default_enabled: :yaml
)
return
unless
SUPPORTED_RUNTIMES
.
include?
(
runtime
)
@startup_time
=
Gitlab
::
Metrics
::
System
.
process_runtime_elapsed_seconds
...
...
spec/lib/gitlab/metrics/boot_time_tracker_spec.rb
View file @
31d451bb
# frozen_string_literal: true
require
'spec_helper'
require
'
fast_
spec_helper'
RSpec
.
describe
Gitlab
::
Metrics
::
BootTimeTracker
do
let
(
:logger
)
{
double
(
'logger'
)
}
...
...
@@ -74,20 +74,6 @@ RSpec.describe Gitlab::Metrics::BootTimeTracker do
tracker
.
track_boot_time!
(
logger:
logger
)
end
end
# TODO: When https://gitlab.com/gitlab-org/gitlab/-/issues/351769 is closed,
# revert to using fast_spec_helper again.
context
'when feature flag is off'
do
it
'does nothing'
do
stub_feature_flags
(
track_application_boot_time:
false
)
expect
(
Gitlab
::
Metrics
::
System
).
not_to
receive
(
:process_runtime_elapsed_seconds
)
expect
(
logger
).
not_to
receive
(
:info
)
expect
(
gauge
).
not_to
receive
(
:set
)
tracker
.
track_boot_time!
(
logger:
logger
)
end
end
end
describe
'#startup_time'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment