Merge branch '353721-password-type-fields-api' into 'master'

Filter integration fields by type

See merge request gitlab-org/gitlab!81564

app/models/integration.rb

@@ -414,7 +414,10 @@ class Integration < ApplicationRecord
   end
 
   def api_field_names
-    fields.pluck(:name).grep_v(/password|token|key|title|description/)
+    fields
+      .reject { _1[:type] == 'password' }
+      .pluck(:name)
+      .grep_v(/password|token|key/)
   end
 
   def global_fields

lib/api/entities/project_integration.rb

@@ -5,19 +5,8 @@ module API
     class ProjectIntegration < Entities::ProjectIntegrationBasic
       # Expose serialized properties
       expose :properties do |integration, options|
-        # TODO: Simplify as part of https://gitlab.com/gitlab-org/gitlab/issues/29404
-
-        attributes =
-          if integration.data_fields_present?
-            integration.data_fields.as_json.keys
-          else
-            integration.properties.keys
-          end
-
-        attributes &= integration.api_field_names
-
-        attributes.each_with_object({}) do |attribute, hash|
-          hash[attribute] = integration.public_send(attribute) # rubocop:disable GitlabSecurity/PublicSend
+        integration.api_field_names.to_h do |name|
+          [name, integration.public_send(name)] # rubocop:disable GitlabSecurity/PublicSend
         end
       end
     end

spec/models/integration_spec.rb

@@ -732,14 +732,21 @@ RSpec.describe Integration do
             { name: 'password' },
             { name: 'password_field' },
             { name: 'some_safe_field' },
-            { name: 'safe_field' }
+            { name: 'safe_field' },
+            { name: 'url' },
+            { name: 'trojan_horse', type: 'password' },
+            { name: 'trojan_gift', type: 'gift' }
           ].shuffle
         end
       end
     end
 
     it 'filters out sensitive fields' do
-      expect(fake_integration.new).to have_attributes(api_field_names: match_array(%w[some_safe_field safe_field]))
+      safe_fields = %w[some_safe_field safe_field url trojan_gift]
+
+      expect(fake_integration.new).to have_attributes(
+        api_field_names: match_array(safe_fields)
+      )
     end
   end