Merge branch '228692-fj-snippet-internal_access_spec' into 'master'

Improve project snippet internal access spec

See merge request gitlab-org/gitlab!38314

ee/spec/features/security/project/snippet/internal_access_spec.rb

@@ -5,10 +5,9 @@ require 'spec_helper'
 RSpec.describe "Internal Project Snippets Access" do
   include AccessMatchers
 
-  let(:project) { create(:project, :internal) }
-
-  let(:internal_snippet) { create(:project_snippet, :internal, project: project, author: project.owner) }
-  let(:private_snippet)  { create(:project_snippet, :private,  project: project, author: project.owner) }
+  let_it_be(:project) { create(:project, :internal) }
+  let_it_be(:internal_snippet) { create(:project_snippet, :internal, project: project, author: project.owner) }
+  let_it_be(:private_snippet)  { create(:project_snippet, :private,  project: project, author: project.owner) }
 
   describe "GET /:project_path/snippets" do
     subject { project_snippets_path(project) }

spec/features/security/project/snippet/internal_access_spec.rb

@@ -5,10 +5,9 @@ require 'spec_helper'
 RSpec.describe "Internal Project Snippets Access" do
   include AccessMatchers
 
-  let(:project) { create(:project, :internal) }
-
-  let(:internal_snippet) { create(:project_snippet, :internal, project: project, author: project.owner) }
-  let(:private_snippet)  { create(:project_snippet, :private,  project: project, author: project.owner) }
+  let_it_be(:project) { create(:project, :internal) }
+  let_it_be(:internal_snippet) { create(:project_snippet, :internal, project: project, author: project.owner) }
+  let_it_be(:private_snippet)  { create(:project_snippet, :private,  project: project, author: project.owner) }
 
   describe "GET /:project_path/snippets" do
     subject { project_snippets_path(project) }