Simplify logic for showing cached count in performance bar

lib/peek/views/active_record.rb

@@ -5,7 +5,6 @@ module Peek
     class ActiveRecord < DetailedView
       DEFAULT_THRESHOLDS = {
         calls: 100,
-        cached_calls: 100,
         duration: 3000,
         individual_call: 1000
       }.freeze
@@ -13,7 +12,6 @@ module Peek
       THRESHOLDS = {
         production: {
           calls: 100,
-          cached_calls: 100,
           duration: 15000,
           individual_call: 5000
         }
@@ -30,25 +28,13 @@ module Peek
       private
 
       def detailed_calls
-        cached_calls? ? "#{calls} | #{cached_calls}" : calls
-      end
-
-      def calls
-        super - cached_calls
+        "#{calls} (#{cached_calls} cached)"
       end
 
       def cached_calls
         detail_store.count { |item| item[:cached] == 'cached' }
       end
 
-      def cached_calls?
-        detail_store.any? { |item| item[:cached] == 'cached' }
-      end
-
-      def warnings
-        (super + warning_for(cached_calls, self.class.thresholds[:cached_calls], label: "#{key} cached calls")).compact
-      end
-
       def setup_subscribers
         super
 

spec/lib/peek/views/active_record_spec.rb

-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.describe Peek::Views::ActiveRecord, :request_store do
-  context 'when a class defines thresholds' do
-    let(:threshold_view) do
-      Class.new(described_class) do
-        def self.thresholds
-          {
-            calls: 1,
-            cached_calls: 1,
-            duration: 10,
-            individual_call: 5
-          }
-        end
-
-        def key
-          'threshold-view'
-        end
-      end.new
-    end
-
-    context 'when the results exceed the cached calls threshold' do
-      before do
-        allow(threshold_view)
-          .to receive(:detail_store).and_return([{ duration: 0.001, cached: 'cached' }, { duration: 0.001, cached: 'cached' }])
-      end
-
-      it 'adds a warning to the results key' do
-        expect(threshold_view.results).to include(warnings: [a_string_matching('threshold-view cached calls')])
-      end
-    end
-  end
-end