Remove signup experiment tracking

Part of ongoing work to remove the signup experiment. This
experiment is over and we're now removing the tracking and later
move the experiment to be the new default.

app/assets/javascripts/pages/registrations/new/index.js

 import LengthValidator from '~/pages/sessions/new/length_validator';
 import UsernameValidator from '~/pages/sessions/new/username_validator';
 import NoEmojiValidator from '~/emoji/no_emoji_validator';
-import Tracking from '~/tracking';
 
 document.addEventListener('DOMContentLoaded', () => {
   new UsernameValidator(); // eslint-disable-line no-new
   new LengthValidator(); // eslint-disable-line no-new
   new NoEmojiValidator(); // eslint-disable-line no-new
 });
-
-document.addEventListener('SnowplowInitialized', () => {
-  if (gon.tracking_data) {
-    const { category, action } = gon.tracking_data;
-
-    if (category && action) {
-      Tracking.event(category, action);
-    }
-  }
-});

app/assets/javascripts/pages/sessions/new/index.js

@@ -5,7 +5,6 @@ import NoEmojiValidator from '../../../emoji/no_emoji_validator';
 import SigninTabsMemoizer from './signin_tabs_memoizer';
 import OAuthRememberMe from './oauth_remember_me';
 import preserveUrlFragment from './preserve_url_fragment';
-import Tracking from '~/tracking';
 
 document.addEventListener('DOMContentLoaded', () => {
   new UsernameValidator(); // eslint-disable-line no-new
@@ -21,16 +20,3 @@ document.addEventListener('DOMContentLoaded', () => {
   // redirected to sign-in after attempting to access a protected URL that included a fragment.
   preserveUrlFragment(window.location.hash);
 });
-
-export default function trackData() {
-  if (gon.tracking_data) {
-    const tab = document.querySelector(".new-session-tabs a[href='#register-pane']");
-    const { category, action, ...data } = gon.tracking_data;
-
-    tab.addEventListener('click', () => {
-      Tracking.event(category, action, data);
-    });
-  }
-}
-
-trackData();

app/controllers/registrations_controller.rb

@@ -17,7 +17,6 @@ class RegistrationsController < Devise::RegistrationsController
 
   def new
     if experiment_enabled?(:signup_flow)
-      track_experiment_event(:signup_flow, 'start') # We want this event to be tracked when the user is _in_ the experimental group
       track_experiment_event(:terms_opt_in, 'start')
 
       @resource = build_resource
@@ -27,9 +26,7 @@ class RegistrationsController < Devise::RegistrationsController
   end
 
   def create
-    track_experiment_event(:signup_flow, 'end') unless experiment_enabled?(:signup_flow) # We want this event to be tracked when the user is _in_ the control group
     track_experiment_event(:terms_opt_in, 'end')
-
     accept_pending_invitations
 
     super do |new_user|
@@ -65,8 +62,6 @@ class RegistrationsController < Devise::RegistrationsController
     result = ::Users::SignupService.new(current_user, user_params).execute
 
     if result[:status] == :success
-      track_experiment_event(:signup_flow, 'end') # We want this event to be tracked when the user is _in_ the experimental group
-
       track_experiment_event(:onboarding_issues, 'signed_up') if ::Gitlab.com? && show_onboarding_issues_experiment?
       return redirect_to new_users_sign_up_group_path if experiment_enabled?(:onboarding_issues) && show_onboarding_issues_experiment?
 

app/controllers/sessions_controller.rb

@@ -25,7 +25,6 @@ class SessionsController < Devise::SessionsController
   before_action :store_unauthenticated_sessions, only: [:new]
   before_action :save_failed_login, if: :action_new_and_failed_login?
   before_action :load_recaptcha
-  before_action :frontend_tracking_data, only: [:new]
 
   after_action :log_failed_login, if: :action_new_and_failed_login?
   after_action :verify_known_sign_in, only: [:create]
@@ -292,11 +291,6 @@ class SessionsController < Devise::SessionsController
       "standard"
     end
   end
-
-  def frontend_tracking_data
-    # We want tracking data pushed to the frontend when the user is _in_ the control group
-    frontend_experimentation_tracking_data(:signup_flow, 'start') unless experiment_enabled?(:signup_flow)
-  end
 end
 
 SessionsController.prepend_if_ee('EE::SessionsController')

spec/controllers/registrations_controller_spec.rb

@@ -18,16 +18,6 @@ RSpec.describe RegistrationsController do
         stub_experiment_for_user(signup_flow: true)
       end
 
-      it 'tracks the event with the right parameters' do
-        expect(Gitlab::Tracking).to receive(:event).with(
-          'Growth::Acquisition::Experiment::SignUpFlow',
-          'start',
-          label: anything,
-          property: 'experimental_group'
-        )
-        subject
-      end
-
       it 'renders new template and sets the resource variable' do
         expect(subject).to render_template(:new)
         expect(response).to have_gitlab_http_status(:ok)
@@ -41,11 +31,6 @@ RSpec.describe RegistrationsController do
         stub_experiment_for_user(signup_flow: false)
       end
 
-      it 'does not track the event' do
-        expect(Gitlab::Tracking).not_to receive(:event)
-        subject
-      end
-
       it 'renders new template and sets the resource variable' do
         subject
         expect(response).to have_gitlab_http_status(:found)
@@ -56,13 +41,6 @@ RSpec.describe RegistrationsController do
     context 'with sign up flow and terms_opt_in experiment being enabled' do
       before do
         stub_experiment(signup_flow: true, terms_opt_in: true)
-
-        expect(Gitlab::Tracking).to receive(:event).with(
-          'Growth::Acquisition::Experiment::SignUpFlow',
-          'start',
-          label: anything,
-          property: 'experimental_group'
-        )
       end
 
       context 'when user is not part of the experiment' do
@@ -331,35 +309,6 @@ RSpec.describe RegistrationsController do
     end
 
     describe 'tracking data' do
-      context 'with the experimental signup flow enabled and the user is part of the control group' do
-        before do
-          stub_experiment(signup_flow: true)
-          stub_experiment_for_user(signup_flow: false)
-        end
-
-        it 'tracks the event with the right parameters' do
-          expect(Gitlab::Tracking).to receive(:event).with(
-            'Growth::Acquisition::Experiment::SignUpFlow',
-            'end',
-            label: anything,
-            property: 'control_group'
-          )
-          post :create, params: user_params
-        end
-      end
-
-      context 'with the experimental signup flow enabled and the user is part of the experimental group' do
-        before do
-          stub_experiment(signup_flow: true)
-          stub_experiment_for_user(signup_flow: true)
-        end
-
-        it 'does not track the event' do
-          expect(Gitlab::Tracking).not_to receive(:event)
-          post :create, params: user_params
-        end
-      end
-
       context 'with sign up flow and terms_opt_in experiment being enabled' do
         subject { post :create, params: user_params }
 
@@ -506,24 +455,6 @@ RSpec.describe RegistrationsController do
     end
   end
 
-  describe '#update_registration' do
-    before do
-      stub_experiment(signup_flow: true)
-      stub_experiment_for_user(signup_flow: true)
-      sign_in(create(:user))
-    end
-
-    it 'tracks the event with the right parameters' do
-      expect(Gitlab::Tracking).to receive(:event).with(
-        'Growth::Acquisition::Experiment::SignUpFlow',
-        'end',
-        label: anything,
-        property: 'experimental_group'
-      )
-      patch :update_registration, params: { user: { role: 'software_developer', setup_for_company: 'false' } }
-    end
-  end
-
   describe '#welcome' do
     subject { get :welcome }
 

spec/controllers/sessions_controller_spec.rb

@@ -59,39 +59,6 @@ RSpec.describe SessionsController do
         end
       end
     end
-
-    describe 'tracking data' do
-      context 'when the user is part of the experimental group' do
-        before do
-          stub_experiment_for_user(signup_flow: true)
-        end
-
-        it 'doesn\'t pass tracking parameters to the frontend' do
-          get(:new)
-          expect(Gon.tracking_data).to be_nil
-        end
-      end
-
-      context 'with the experimental signup flow enabled and the user is part of the control group' do
-        before do
-          stub_experiment(signup_flow: true)
-          stub_experiment_for_user(signup_flow: false)
-          allow_any_instance_of(described_class).to receive(:experimentation_subject_id).and_return('uuid')
-        end
-
-        it 'passes the right tracking parameters to the frontend' do
-          get(:new)
-          expect(Gon.tracking_data).to eq(
-            {
-              category: 'Growth::Acquisition::Experiment::SignUpFlow',
-              action: 'start',
-              label: 'uuid',
-              property: 'control_group'
-            }
-          )
-        end
-      end
-    end
   end
 
   describe '#create' do

spec/frontend/pages/sessions/new/signin_tabs_memoizer_spec.js

 import AccessorUtilities from '~/lib/utils/accessor';
 import SigninTabsMemoizer from '~/pages/sessions/new/signin_tabs_memoizer';
-import trackData from '~/pages/sessions/new/index';
-import Tracking from '~/tracking';
 import { useLocalStorageSpy } from 'helpers/local_storage_helper';
 
 useLocalStorageSpy();
@@ -99,50 +97,6 @@ describe('SigninTabsMemoizer', () => {
     });
   });
 
-  describe('trackData', () => {
-    beforeEach(() => {
-      jest.spyOn(Tracking, 'event').mockImplementation(() => {});
-    });
-
-    describe('with tracking data', () => {
-      beforeEach(() => {
-        gon.tracking_data = {
-          category: 'Growth::Acquisition::Experiment::SignUpFlow',
-          action: 'start',
-          label: 'uuid',
-          property: 'control_group',
-        };
-        trackData();
-      });
-
-      it('should track data when the "click" event of the register tab is triggered', () => {
-        document.querySelector('a[href="#register-pane"]').click();
-
-        expect(Tracking.event).toHaveBeenCalledWith(
-          'Growth::Acquisition::Experiment::SignUpFlow',
-          'start',
-          {
-            label: 'uuid',
-            property: 'control_group',
-          },
-        );
-      });
-    });
-
-    describe('without tracking data', () => {
-      beforeEach(() => {
-        gon.tracking_data = undefined;
-        trackData();
-      });
-
-      it('should not track data when the "click" event of the register tab is triggered', () => {
-        document.querySelector('a[href="#register-pane"]').click();
-
-        expect(Tracking.event).not.toHaveBeenCalled();
-      });
-    });
-  });
-
   describe('saveData', () => {
     beforeEach(() => {
       memo = {