Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
391e548d
Commit
391e548d
authored
Feb 17, 2020
by
Tobias Spagert
Committed by
Fatih Acet
Feb 17, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Replace underscore with lodash for ./app/assets/javascripts/error_tracking
parent
9785b85e
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
9 additions
and
4 deletions
+9
-4
app/assets/javascripts/error_tracking/components/error_tracking_list.vue
...scripts/error_tracking/components/error_tracking_list.vue
+2
-2
app/assets/javascripts/error_tracking/components/stacktrace_entry.vue
...avascripts/error_tracking/components/stacktrace_entry.vue
+2
-2
changelogs/unreleased/resolve_gitlab_issue_196658.yml
changelogs/unreleased/resolve_gitlab_issue_196658.yml
+5
-0
No files found.
app/assets/javascripts/error_tracking/components/error_tracking_list.vue
View file @
391e548d
...
@@ -19,7 +19,7 @@ import AccessorUtils from '~/lib/utils/accessor';
...
@@ -19,7 +19,7 @@ import AccessorUtils from '~/lib/utils/accessor';
import
Icon
from
'
~/vue_shared/components/icon.vue
'
;
import
Icon
from
'
~/vue_shared/components/icon.vue
'
;
import
TimeAgo
from
'
~/vue_shared/components/time_ago_tooltip.vue
'
;
import
TimeAgo
from
'
~/vue_shared/components/time_ago_tooltip.vue
'
;
import
{
__
}
from
'
~/locale
'
;
import
{
__
}
from
'
~/locale
'
;
import
_
from
'
underscore
'
;
import
{
isEmpty
}
from
'
lodash
'
;
export
const
tableDataClass
=
'
table-col d-flex d-sm-table-cell align-items-center
'
;
export
const
tableDataClass
=
'
table-col d-flex d-sm-table-cell align-items-center
'
;
...
@@ -139,7 +139,7 @@ export default {
...
@@ -139,7 +139,7 @@ export default {
'
cursor
'
,
'
cursor
'
,
]),
]),
paginationRequired
()
{
paginationRequired
()
{
return
!
_
.
isEmpty
(
this
.
pagination
);
return
!
isEmpty
(
this
.
pagination
);
},
},
},
},
watch
:
{
watch
:
{
...
...
app/assets/javascripts/error_tracking/components/stacktrace_entry.vue
View file @
391e548d
<
script
>
<
script
>
import
_
from
'
underscore
'
;
import
{
escape
as
esc
}
from
'
lodash
'
;
import
{
GlTooltip
}
from
'
@gitlab/ui
'
;
import
{
GlTooltip
}
from
'
@gitlab/ui
'
;
import
{
__
,
sprintf
}
from
'
~/locale
'
;
import
{
__
,
sprintf
}
from
'
~/locale
'
;
import
ClipboardButton
from
'
~/vue_shared/components/clipboard_button.vue
'
;
import
ClipboardButton
from
'
~/vue_shared/components/clipboard_button.vue
'
;
...
@@ -62,7 +62,7 @@ export default {
...
@@ -62,7 +62,7 @@ export default {
?
sprintf
(
?
sprintf
(
__
(
`%{spanStart}in%{spanEnd} %{errorFn}`
),
__
(
`%{spanStart}in%{spanEnd} %{errorFn}`
),
{
{
errorFn
:
`<strong>
${
_
.
escape
(
this
.
errorFn
)}
</strong>`
,
errorFn
:
`<strong>
${
esc
(
this
.
errorFn
)}
</strong>`
,
spanStart
:
`<span class="text-tertiary">`
,
spanStart
:
`<span class="text-tertiary">`
,
spanEnd
:
`</span>`
,
spanEnd
:
`</span>`
,
},
},
...
...
changelogs/unreleased/resolve_gitlab_issue_196658.yml
0 → 100644
View file @
391e548d
---
title
:
Replace underscore with lodash for ./app/assets/javascripts/error_tracking
merge_request
:
25143
author
:
Tobias Spagert
type
:
other
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment