Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
398a5462
Commit
398a5462
authored
Apr 13, 2021
by
Nathan Friend
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove deployment_frequency_charts feature flag
This commit removes the `deployment_frequency_charts` feature flag.
parent
47d8b264
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
5 additions
and
21 deletions
+5
-21
ee/app/helpers/ee/graph_helper.rb
ee/app/helpers/ee/graph_helper.rb
+0
-1
ee/changelogs/unreleased/nfriend-remove-deployment_frequency_charts-feature-flag.yml
...riend-remove-deployment_frequency_charts-feature-flag.yml
+5
-0
ee/config/feature_flags/development/deployment_frequency_charts.yml
...feature_flags/development/deployment_frequency_charts.yml
+0
-8
ee/spec/helpers/ee/graph_helper_spec.rb
ee/spec/helpers/ee/graph_helper_spec.rb
+0
-12
No files found.
ee/app/helpers/ee/graph_helper.rb
View file @
398a5462
...
@@ -6,7 +6,6 @@ module EE
...
@@ -6,7 +6,6 @@ module EE
override
:should_render_deployment_frequency_charts
override
:should_render_deployment_frequency_charts
def
should_render_deployment_frequency_charts
def
should_render_deployment_frequency_charts
return
false
unless
::
Feature
.
enabled?
(
:deployment_frequency_charts
,
@project
,
default_enabled:
true
)
return
false
unless
@project
.
feature_available?
(
:dora4_analytics
)
return
false
unless
@project
.
feature_available?
(
:dora4_analytics
)
can?
(
current_user
,
:read_dora4_analytics
,
@project
)
can?
(
current_user
,
:read_dora4_analytics
,
@project
)
...
...
ee/changelogs/unreleased/nfriend-remove-deployment_frequency_charts-feature-flag.yml
0 → 100644
View file @
398a5462
---
title
:
Remove deployment_frequency_charts feature flag
merge_request
:
59289
author
:
type
:
removed
ee/config/feature_flags/development/deployment_frequency_charts.yml
deleted
100644 → 0
View file @
47d8b264
---
name
:
deployment_frequency_charts
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/50885
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/296893
milestone
:
'
13.8'
type
:
development
group
:
group::release
default_enabled
:
true
ee/spec/helpers/ee/graph_helper_spec.rb
View file @
398a5462
...
@@ -16,12 +16,6 @@ RSpec.describe EE::GraphHelper do
...
@@ -16,12 +16,6 @@ RSpec.describe EE::GraphHelper do
end
end
describe
'#should_render_deployment_frequency_charts'
do
describe
'#should_render_deployment_frequency_charts'
do
let
(
:is_flag_enabled
)
{
true
}
before
do
stub_feature_flags
(
deployment_frequency_charts:
is_flag_enabled
)
end
shared_examples
'returns true'
do
shared_examples
'returns true'
do
it
{
expect
(
should_render_deployment_frequency_charts
).
to
be
(
true
)
}
it
{
expect
(
should_render_deployment_frequency_charts
).
to
be
(
true
)
}
end
end
...
@@ -38,12 +32,6 @@ RSpec.describe EE::GraphHelper do
...
@@ -38,12 +32,6 @@ RSpec.describe EE::GraphHelper do
it_behaves_like
'returns false'
it_behaves_like
'returns false'
end
end
context
'when the feature flag is disabled'
do
let
(
:is_flag_enabled
)
{
false
}
it_behaves_like
'returns false'
end
context
'when the user does not have permission'
do
context
'when the user does not have permission'
do
let
(
:is_user_authorized
)
{
false
}
let
(
:is_user_authorized
)
{
false
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment