Commit 3a190ba0 authored by Peter Hegman's avatar Peter Hegman

Merge branch '349530-fix-code-block-toggle-button' into 'master'

Fix toggle code block button in the Content Editor

See merge request gitlab-org/gitlab!78071
parents 40832d47 766da0c2
...@@ -14,9 +14,20 @@ export default CodeBlockHighlight.extend({ ...@@ -14,9 +14,20 @@ export default CodeBlockHighlight.extend({
}, },
]; ];
}, },
addCommands() {
return {
setFrontmatter: (attributes) => ({ commands }) => {
return commands.setNode(this.name, attributes);
},
toggleFrontmatter: (attributes) => ({ commands }) => {
return commands.toggleNode(this.name, 'paragraph', attributes);
},
};
},
addNodeView() { addNodeView() {
return new VueNodeViewRenderer(FrontmatterWrapper); return new VueNodeViewRenderer(FrontmatterWrapper);
}, },
addInputRules() { addInputRules() {
return []; return [];
}, },
......
import Frontmatter from '~/content_editor/extensions/frontmatter'; import Frontmatter from '~/content_editor/extensions/frontmatter';
import CodeBlockHighlight from '~/content_editor/extensions/code_block_highlight';
import { createTestEditor, createDocBuilder, triggerNodeInputRule } from '../test_utils'; import { createTestEditor, createDocBuilder, triggerNodeInputRule } from '../test_utils';
describe('content_editor/extensions/frontmatter', () => { describe('content_editor/extensions/frontmatter', () => {
let tiptapEditor; let tiptapEditor;
let doc; let doc;
let p; let frontmatter;
let codeBlock;
beforeEach(() => { beforeEach(() => {
tiptapEditor = createTestEditor({ extensions: [Frontmatter] }); tiptapEditor = createTestEditor({ extensions: [Frontmatter, CodeBlockHighlight] });
({ ({
builders: { doc, p }, builders: { doc, codeBlock, frontmatter },
} = createDocBuilder({ } = createDocBuilder({
tiptapEditor, tiptapEditor,
names: { names: {
frontmatter: { nodeType: Frontmatter.name }, frontmatter: { nodeType: Frontmatter.name },
codeBlock: { nodeType: CodeBlockHighlight.name },
}, },
})); }));
}); });
it('does not insert a frontmatter block when executing code block input rule', () => { it('does not insert a frontmatter block when executing code block input rule', () => {
const expectedDoc = doc(p('')); const expectedDoc = doc(codeBlock(''));
const inputRuleText = '``` '; const inputRuleText = '``` ';
triggerNodeInputRule({ tiptapEditor, inputRuleText }); triggerNodeInputRule({ tiptapEditor, inputRuleText });
expect(tiptapEditor.getJSON()).toEqual(expectedDoc.toJSON()); expect(tiptapEditor.getJSON()).toEqual(expectedDoc.toJSON());
}); });
it.each`
command | result | resultDesc
${'toggleCodeBlock'} | ${() => doc(codeBlock(''))} | ${'code block element'}
${'setCodeBlock'} | ${() => doc(codeBlock(''))} | ${'code block element'}
${'setFrontmatter'} | ${() => doc(frontmatter(''))} | ${'frontmatter element'}
${'toggleFrontmatter'} | ${() => doc(frontmatter(''))} | ${'frontmatter element'}
`('executing $command should generate a document with a $resultDesc', ({ command, result }) => {
const expectedDoc = result();
tiptapEditor.commands[command]();
expect(tiptapEditor.getJSON()).toEqual(expectedDoc.toJSON());
});
}); });
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment