Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
3a33c34f
Commit
3a33c34f
authored
Feb 24, 2020
by
Jason Goodman
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove recommendation to use add_column for small tables
parent
becfc8bc
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
0 additions
and
4 deletions
+0
-4
doc/development/migration_style_guide.md
doc/development/migration_style_guide.md
+0
-4
No files found.
doc/development/migration_style_guide.md
View file @
3a33c34f
...
@@ -415,10 +415,6 @@ default values if absolutely necessary. There is a RuboCop cop that will fail if
...
@@ -415,10 +415,6 @@ default values if absolutely necessary. There is a RuboCop cop that will fail if
this method is used on some tables that are very large on GitLab.com, which
this method is used on some tables that are very large on GitLab.com, which
would cause other issues.
would cause other issues.
For a small table (such as an empty one or one with less than
`1,000`
records),
use
`add_column`
and
`change_column_default`
in a single-transaction migration,
combining it with other operations that don't require
`disable_ddl_transaction!`
.
## Changing the column default
## Changing the column default
One might think that changing a default column with
`change_column_default`
is an
One might think that changing a default column with
`change_column_default`
is an
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment