Merge branch 'refactor-many-tests-to-use-login-flow' into 'master'

Refactor many tests to use the login flow See merge request gitlab-org/gitlab!21044

Merge branch 'refactor-many-tests-to-use-login-flow' into 'master'
Refactor many tests to use the login flow See merge request gitlab-org/gitlab!21044
3acfa7cb · Mark Lapierre · c7144fa3 · 356645b7 · 3acfa7cb · 3acfa7cb
Commit 3acfa7cb authored Dec 02, 2019 by Mark Lapierre
45 changed files
--- a/qa/qa/specs/features/browser_ui/1_manage/group/create_group_with_mattermost_team_spec.rb
+++ b/qa/qa/specs/features/browser_ui/1_manage/group/create_group_with_mattermost_team_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Configure', :orchestrated, :mattermost do
    describe 'Mattermost support' do
      it 'user creates a group with a mattermost team' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        Page::Main::Menu.perform(&:go_to_groups)
        Page::Dashboard::Groups.perform do |groups|

--- a/qa/qa/specs/features/browser_ui/1_manage/group/transfer_project_spec.rb
+++ b/qa/qa/specs/features/browser_ui/1_manage/group/transfer_project_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Manage' do
    describe 'Project transfer between groups' do
      it 'user transfers a project between groups' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        source_group = Resource::Group.fabricate_via_api! do |group|
          group.path = 'source-group'

--- a/qa/qa/specs/features/browser_ui/1_manage/login/log_in_spec.rb
+++ b/qa/qa/specs/features/browser_ui/1_manage/login/log_in_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Manage', :smoke do
    describe 'basic user login' do
      it 'user logs in using basic credentials and logs out' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        Page::Main::Menu.perform do |menu|
          expect(menu).to have_personal_area

--- a/qa/qa/specs/features/browser_ui/1_manage/login/log_into_gitlab_via_ldap_spec.rb
+++ b/qa/qa/specs/features/browser_ui/1_manage/login/log_into_gitlab_via_ldap_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Manage', :orchestrated, :ldap_no_tls, :ldap_tls do
    describe 'LDAP login' do
      it 'user logs into GitLab using LDAP credentials' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        Page::Main::Menu.perform do |menu|
          expect(menu).to have_personal_area

--- a/qa/qa/specs/features/browser_ui/1_manage/login/log_into_mattermost_via_gitlab_spec.rb
+++ b/qa/qa/specs/features/browser_ui/1_manage/login/log_into_mattermost_via_gitlab_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Manage', :orchestrated, :mattermost do
    describe 'Mattermost login' do
      it 'user logs into Mattermost using GitLab OAuth' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        Support::Retrier.retry_on_exception do
          Runtime::Browser.visit(:mattermost, Page::Mattermost::Login)

--- a/qa/qa/specs/features/browser_ui/1_manage/project/add_project_member_spec.rb
+++ b/qa/qa/specs/features/browser_ui/1_manage/project/add_project_member_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Manage' do
    describe 'Add project member' do
      it 'user adds project member' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        user = Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_1, Runtime::Env.gitlab_qa_password_1)

--- a/qa/qa/specs/features/browser_ui/1_manage/project/create_project_spec.rb
+++ b/qa/qa/specs/features/browser_ui/1_manage/project/create_project_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Manage', :smoke do
    describe 'Project creation' do
      it 'user creates a new project' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        created_project = Resource::Project.fabricate_via_browser_ui! do |project|
          project.name = 'awesome-project'

--- a/qa/qa/specs/features/browser_ui/1_manage/project/import_github_repo_spec.rb
+++ b/qa/qa/specs/features/browser_ui/1_manage/project/import_github_repo_spec.rb
@@ -23,8 +23,7 @@ module QA
      end
      it 'user imports a GitHub repo' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        imported_project # import the project

--- a/qa/qa/specs/features/browser_ui/1_manage/project/view_project_activity_spec.rb
+++ b/qa/qa/specs/features/browser_ui/1_manage/project/view_project_activity_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Manage' do
    describe 'Project activity' do
      it 'user creates an event in the activity page upon Git push' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        project_push = Resource::Repository::ProjectPush.fabricate! do |push|
          push.file_name = 'README.md'

--- a/qa/qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_spec.rb
+++ b/qa/qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Create' do
    describe 'Create a new merge request' do
      before do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        @project = Resource::Project.fabricate_via_api! do |project|
          project.name = 'project'

--- a/qa/qa/specs/features/browser_ui/3_create/merge_request/merge_merge_request_from_fork_spec.rb
+++ b/qa/qa/specs/features/browser_ui/3_create/merge_request/merge_merge_request_from_fork_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Create' do
    describe 'Merge request creation from fork' do
      it 'user forks a project, submits a merge request and maintainer merges it' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        merge_request = Resource::MergeRequestFromFork.fabricate! do |merge_request|
          merge_request.fork_branch = 'feature-branch'

--- a/qa/qa/specs/features/browser_ui/3_create/merge_request/rebase_merge_request_spec.rb
+++ b/qa/qa/specs/features/browser_ui/3_create/merge_request/rebase_merge_request_spec.rb
@@ -5,8 +5,7 @@ module QA
  context 'Create', :quarantine do
    describe 'Merge request rebasing' do
      it 'user rebases source branch of merge request' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        project = Resource::Project.fabricate! do |project|
          project.name = "only-fast-forward"

--- a/qa/qa/specs/features/browser_ui/3_create/merge_request/squash_merge_request_spec.rb
+++ b/qa/qa/specs/features/browser_ui/3_create/merge_request/squash_merge_request_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Create' do
    describe 'Merge request squashing' do
      it 'user squashes commits while merging' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        project = Resource::Project.fabricate! do |project|
          project.name = "squash-before-merge"

--- a/qa/qa/specs/features/browser_ui/3_create/repository/add_list_delete_branches_spec.rb
+++ b/qa/qa/specs/features/browser_ui/3_create/repository/add_list_delete_branches_spec.rb
@@ -16,8 +16,7 @@ module QA
      commit_message_of_third_branch = "Add #{file_third_branch}"
      before do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        project = Resource::Project.fabricate! do |proj|
          proj.name = 'project-qa-test'

--- a/qa/qa/specs/features/browser_ui/3_create/repository/add_ssh_key_spec.rb
+++ b/qa/qa/specs/features/browser_ui/3_create/repository/add_ssh_key_spec.rb
@@ -6,8 +6,7 @@ module QA
      let(:key_title) { "key for ssh tests #{Time.now.to_f}" }
      it 'user adds and then removes an SSH key', :smoke do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        key = Resource::SSHKey.fabricate! do |resource|
          resource.title = key_title

--- a/qa/qa/specs/features/browser_ui/3_create/repository/protocol_v2_push_http_spec.rb
+++ b/qa/qa/specs/features/browser_ui/3_create/repository/protocol_v2_push_http_spec.rb
@@ -6,8 +6,7 @@ module QA
  context 'Create', :quarantine do
    describe 'Push over HTTP using Git protocol version 2', :requires_git_protocol_v2 do
      it 'user pushes to the repository' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        # Create a project to push to
        project = Resource::Project.fabricate! do |project|

--- a/qa/qa/specs/features/browser_ui/3_create/repository/protocol_v2_push_ssh_spec.rb
+++ b/qa/qa/specs/features/browser_ui/3_create/repository/protocol_v2_push_ssh_spec.rb
@@ -17,20 +17,15 @@ module QA
        end
      end
-      def login
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
-        Page::Main::Login.perform(&:sign_in_using_credentials)
-      end
      around do |example|
        # Create an SSH key to be used with Git
-        login
+        Flow::Login.sign_in
        ssh_key
        example.run
        # Remove the SSH key
-        login
+        Flow::Login.sign_in
        Page::Main::Menu.perform(&:click_settings_link)
        Page::Profile::Menu.perform(&:click_ssh_keys)
        Page::Profile::SSHKeys.perform do |ssh_keys|

--- a/qa/qa/specs/features/browser_ui/3_create/repository/push_http_private_token_spec.rb
+++ b/qa/qa/specs/features/browser_ui/3_create/repository/push_http_private_token_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Create' do
    describe 'Git push over HTTP', :ldap_no_tls do
      it 'user using a personal access token pushes code to the repository' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        access_token = Resource::PersonalAccessToken.fabricate!.access_token

--- a/qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_spec.rb
+++ b/qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Create' do
    describe 'Git push over HTTP', :ldap_no_tls do
      it 'user pushes code to the repository' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        project_push = Resource::Repository::ProjectPush.fabricate! do |push|
          push.file_name = 'README.md'

--- a/qa/qa/specs/features/browser_ui/3_create/repository/use_ssh_key_spec.rb
+++ b/qa/qa/specs/features/browser_ui/3_create/repository/use_ssh_key_spec.rb
@@ -9,8 +9,7 @@ module QA
      let(:key_title) { "key for ssh tests #{Time.now.to_f}" }
      it 'user adds an ssh key and pushes code to the repository' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        key = Resource::SSHKey.fabricate! do |resource|
          resource.title = key_title

--- a/qa/qa/specs/features/browser_ui/3_create/snippet/create_snippet_spec.rb
+++ b/qa/qa/specs/features/browser_ui/3_create/snippet/create_snippet_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Create', :smoke do
    describe 'Snippet creation' do
      it 'User creates a snippet' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        Page::Main::Menu.perform(&:go_to_snippets)

--- a/qa/qa/specs/features/browser_ui/3_create/wiki/create_edit_clone_push_wiki_spec.rb
+++ b/qa/qa/specs/features/browser_ui/3_create/wiki/create_edit_clone_push_wiki_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Create' do
    describe 'Wiki management' do
      it 'user creates, edits, clones, and pushes to the wiki' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        wiki = Resource::Wiki.fabricate! do |resource|
          resource.title = 'Home'

--- a/qa/qa/specs/features/browser_ui/6_release/deploy_key/add_deploy_key_spec.rb
+++ b/qa/qa/specs/features/browser_ui/6_release/deploy_key/add_deploy_key_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Release' do
    describe 'Deploy key creation' do
      it 'user adds a deploy key' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        key = Runtime::Key::RSA.new
        deploy_key_title = 'deploy key title'

--- a/qa/qa/specs/features/browser_ui/6_release/deploy_key/clone_using_deploy_key_spec.rb
+++ b/qa/qa/specs/features/browser_ui/6_release/deploy_key/clone_using_deploy_key_spec.rb
@@ -10,8 +10,7 @@ module QA
        @job_log_json_flag_enabled = Runtime::Feature.enabled?('job_log_json')
        Runtime::Feature.disable('job_log_json') if @job_log_json_flag_enabled
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        @runner_name = "qa-runner-#{Time.now.to_i}"

--- a/qa/qa/specs/features/browser_ui/6_release/deploy_token/add_deploy_token_spec.rb
+++ b/qa/qa/specs/features/browser_ui/6_release/deploy_token/add_deploy_token_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Release' do
    describe 'Deploy token creation' do
      it 'user adds a deploy token' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        deploy_token_name = 'deploy token name'
        one_week_from_now = Date.today + 7

--- a/qa/qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb
@@ -26,8 +26,7 @@ module QA
          menu.sign_out if menu.has_personal_area?(wait: 0)
        end
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
      end
      context 'when restricted by another ip address' do

--- a/qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb
@@ -119,8 +119,7 @@ module QA
      def sign_in
        unless Page::Main::Menu.perform { |p| p.has_personal_area?(wait: 0) }
-          Runtime::Browser.visit(:gitlab, Page::Main::Login)
+          Flow::Login.sign_in
-          Page::Main::Login.perform(&:sign_in_using_credentials)
        end
      end
    end

--- a/qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb
@@ -37,8 +37,7 @@ module QA
      context 'built-in', :requires_admin do
        before do
-          Runtime::Browser.visit(:gitlab, Page::Main::Login)
+          Flow::Login.sign_in_as_admin
-          Page::Main::Login.perform(&:sign_in_using_admin_credentials)
          @group = Resource::Group.fabricate_via_api!
        end
@@ -68,8 +67,7 @@ module QA
      # Failure issue: https://gitlab.com/gitlab-org/quality/staging/issues/61
      context 'instance level', :quarantine, :requires_admin do
        before do
-          Runtime::Browser.visit(:gitlab, Page::Main::Login)
+          Flow::Login.sign_in_as_admin
-          Page::Main::Login.perform(&:sign_in_using_admin_credentials)
          Page::Main::Menu.perform(&:go_to_admin_area)
          Page::Admin::Menu.perform(&:go_to_template_settings)
@@ -111,8 +109,7 @@ module QA
      context 'group level' do
        before do
-          Runtime::Browser.visit(:gitlab, Page::Main::Login)
+          Flow::Login.sign_in
-          Page::Main::Login.perform(&:sign_in_using_credentials)
          Page::Main::Menu.perform(&:go_to_groups)
          Page::Dashboard::Groups.perform { |groups| groups.click_group(Runtime::Namespace.sandbox_name) }

--- a/qa/qa/specs/features/ee/browser_ui/3_create/design_management_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/3_create/design_management_spec.rb
@@ -9,8 +9,7 @@ module QA
      let(:annotation) { "This design is great!" }
      before do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
      end
      it 'user adds a design and annotation' do

--- a/qa/qa/specs/features/ee/browser_ui/3_create/elasticsearch/elasticsearch_reindexing_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/3_create/elasticsearch/elasticsearch_reindexing_spec.rb
@@ -10,8 +10,7 @@ module QA
        @project_file_name = 'elasticsearch.rb'
        @project_file_content = 'elasticsearch: true'
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        QA::EE::Resource::Settings::Elasticsearch.fabricate_via_browser_ui!

--- a/qa/qa/specs/features/ee/browser_ui/3_create/jenkins/jenkins_build_status_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/3_create/jenkins/jenkins_build_status_spec.rb
@@ -105,8 +105,7 @@ module QA
      end
      def login_to_gitlab
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
      end
      def patch_host_name(host_name, container_name)
@@ -131,8 +130,7 @@ module QA
      def allow_requests_to_local_networks
        Page::Main::Menu.perform(&:sign_out_if_signed_in)
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in_as_admin
-        Page::Main::Login.perform(&:sign_in_using_admin_credentials)
        Page::Main::Menu.perform(&:go_to_admin_area)
        Page::Admin::Menu.perform(&:go_to_network_settings)

--- a/qa/qa/specs/features/ee/browser_ui/3_create/merge_request/add_batch_comments_in_merge_request_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/3_create/merge_request/add_batch_comments_in_merge_request_spec.rb
@@ -17,8 +17,7 @@ module QA
      end
      it 'user submits, discards batch comments' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        merge_request.visit!

--- a/qa/qa/specs/features/ee/browser_ui/3_create/repository/assign_code_owners_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/3_create/repository/assign_code_owners_spec.rb
@@ -19,8 +19,7 @@ module QA
        project.add_member(approver, Resource::Members::AccessLevel::DEVELOPER)
        project.add_member(non_approver, Resource::Members::AccessLevel::DEVELOPER)
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        project.visit!
      end

--- a/qa/qa/specs/features/ee/browser_ui/3_create/repository/code_owners_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/3_create/repository/code_owners_spec.rb
@@ -18,8 +18,7 @@ module QA
      before do
        # Add two new users to a project as members
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        @user = Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_1, Runtime::Env.gitlab_qa_password_1)
        @user2 = Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_2, Runtime::Env.gitlab_qa_password_2)

--- a/qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb
@@ -4,8 +4,7 @@ module QA
  context 'Create' do
    describe 'File Locking' do
      before do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        @user_one = Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_1, Runtime::Env.gitlab_qa_password_1)
        @user_two = Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_2, Runtime::Env.gitlab_qa_password_2)

--- a/qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_http_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_http_spec.rb
@@ -6,8 +6,7 @@ module QA
    # See https://gitlab.com/gitlab-org/gitlab/issues/13769
    describe 'Pull mirror a repository over HTTP', :requires_admin do
      it 'configures and syncs a (pull) mirrored repository with password auth' do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in_as_admin
-        Page::Main::Login.perform(&:sign_in_using_admin_credentials)
        source = Resource::Repository::ProjectPush.fabricate! do |project_push|
          project_push.project_name = 'pull-mirror-source-project'

--- a/qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_ssh_with_key_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_ssh_with_key_spec.rb
@@ -20,8 +20,7 @@ module QA
      end
      before do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        target_project.visit!
      end

--- a/qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb
@@ -161,8 +161,7 @@ module QA
      end
      def prepare
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        @project = Resource::Project.fabricate_via_api! do |project|
          project.name = 'push_rules'

--- a/qa/qa/specs/features/ee/browser_ui/3_create/web_ide/web_terminal_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/3_create/web_ide/web_terminal_spec.rb
@@ -42,8 +42,7 @@ module QA
          END
        end
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        project.visit!
      end

--- a/qa/qa/specs/features/ee/browser_ui/5_package/maven_repository_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/5_package/maven_repository_spec.rb
@@ -10,8 +10,7 @@ module QA
      let(:package_name) { "#{group_id}/#{artifact_id}".tr('.', '/') }
      let(:auth_token) do
        unless Page::Main::Menu.perform(&:signed_in?)
-          Runtime::Browser.visit(:gitlab, Page::Main::Login)
+          Flow::Login.sign_in
-          Page::Main::Login.perform(&:sign_in_using_credentials)
        end
        Resource::PersonalAccessToken.fabricate!.access_token

--- a/qa/qa/specs/features/ee/browser_ui/5_package/npm_registry_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/5_package/npm_registry_spec.rb
@@ -9,8 +9,7 @@ module QA
      let(:package_name) { "@#{registry_scope}/#{project.name}" }
      let(:auth_token) do
        unless Page::Main::Menu.perform(&:signed_in?)
-          Runtime::Browser.visit(:gitlab, Page::Main::Login)
+          Flow::Login.sign_in
-          Page::Main::Login.perform(&:sign_in_using_credentials)
        end
        Resource::PersonalAccessToken.fabricate!.access_token

--- a/qa/qa/specs/features/ee/browser_ui/6_release/multi-project_pipelines_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/6_release/multi-project_pipelines_spec.rb
@@ -61,8 +61,7 @@ module QA
          CI
        end
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        Resource::MergeRequest.fabricate_via_api! do |merge_request|
          merge_request.project = upstream_project

--- a/qa/qa/specs/features/ee/browser_ui/6_release/pipelines_for_merged_results_and_merge_trains_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/6_release/pipelines_for_merged_results_and_merge_trains_spec.rb
@@ -30,8 +30,7 @@ module QA
      end
      before do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        @project.visit!

--- a/qa/qa/specs/features/ee/browser_ui/secure/create_merge_request_with_secure_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/secure/create_merge_request_with_secure_spec.rb
@@ -28,8 +28,7 @@ module QA
        @job_log_json_flag_enabled = Runtime::Feature.enabled?('job_log_json')
        Runtime::Feature.disable('job_log_json') if @job_log_json_flag_enabled
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        @project = Resource::Project.fabricate_via_api! do |p|
          p.name = Runtime::Env.auto_devops_project_name || 'project-with-secure'

--- a/qa/qa/specs/features/ee/browser_ui/secure/license_compliance_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/secure/license_compliance_spec.rb
@@ -9,8 +9,7 @@ module QA
    describe 'License Compliance settings page' do
      before do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        @project = Resource::Project.fabricate_via_api! do |project|
          project.name = Runtime::Env.auto_devops_project_name || 'project-with-secure'
@@ -53,8 +52,7 @@ module QA
        @job_log_json_flag_enabled = Runtime::Feature.enabled?('job_log_json')
        Runtime::Feature.disable('job_log_json') if @job_log_json_flag_enabled
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Flow::Login.sign_in
-        Page::Main::Login.perform(&:sign_in_using_credentials)
        @project = Resource::Project.fabricate_via_api! do |project|
          project.name = Runtime::Env.auto_devops_project_name || 'project-with-secure'