Commit 3b36620c authored by Rémy Coutable's avatar Rémy Coutable

Merge branch '217719-improve-danger-bot-layout-for-telemetry-review' into 'master'

Improve danger bot layout for telemetry review

Closes #217719

See merge request gitlab-org/gitlab!32071
parents fb846ca8 28e00627
# frozen_string_literal: true # frozen_string_literal: true
TELEMETRY_CHANGED_FILES_MESSAGE = <<~MSG TELEMETRY_CHANGED_FILES_MESSAGE = <<~MSG
This merge request includes changes for which a review from the Data team and Telemetry team is recommended. For the following files, a review from the [Data team and Telemetry team](https://gitlab.com/groups/gitlab-org/growth/telemetry/engineers/-/group_members?with_inherited_permissions=exclude) is recommended
Please reach out to @gitlab-org/growth/telemetry/engineers group for a review. Please check the ~telemetry [guide](https://docs.gitlab.com/ee/development/telemetry/usage_ping.html) and reach out to @gitlab-org/growth/telemetry/engineers group for a review.
MSG
%<changed_files>s
USAGE_DATA_FILES_MESSAGE = <<~MSG
For the following files, a review from the [Data team and Telemetry team](https://gitlab.com/groups/gitlab-org/growth/telemetry/engineers/-/group_members?with_inherited_permissions=exclude) is recommended:
MSG MSG
tracking_files = [ tracking_files = [
...@@ -16,7 +15,7 @@ tracking_files = [ ...@@ -16,7 +15,7 @@ tracking_files = [
'spec/helpers/tracking_helper_spec.rb', 'spec/helpers/tracking_helper_spec.rb',
'app/assets/javascripts/tracking.js', 'app/assets/javascripts/tracking.js',
'spec/frontend/tracking_spec.js' 'spec/frontend/tracking_spec.js'
] ]
usage_data_changed_files = git.modified_files.grep(%r{usage_data}) usage_data_changed_files = git.modified_files.grep(%r{usage_data})
snowplow_events_changed_files = git.modified_files & tracking_files snowplow_events_changed_files = git.modified_files & tracking_files
...@@ -24,9 +23,7 @@ snowplow_events_changed_files = git.modified_files & tracking_files ...@@ -24,9 +23,7 @@ snowplow_events_changed_files = git.modified_files & tracking_files
changed_files = (usage_data_changed_files + snowplow_events_changed_files) changed_files = (usage_data_changed_files + snowplow_events_changed_files)
if changed_files.any? if changed_files.any?
warn format(TELEMETRY_CHANGED_FILES_MESSAGE) warn format(TELEMETRY_CHANGED_FILES_MESSAGE, changed_files: helper.markdown_list(changed_files))
markdown(USAGE_DATA_FILES_MESSAGE + helper.markdown_list(changed_files))
telemetry_labels = ['telemetry'] telemetry_labels = ['telemetry']
telemetry_labels << 'telemetry::review pending' unless helper.mr_has_labels?('telemetry::reviewed') telemetry_labels << 'telemetry::review pending' unless helper.mr_has_labels?('telemetry::reviewed')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment