Commit 3b54907f authored by Filipa Lacerda's avatar Filipa Lacerda

Merge branch 'use-title' into 'master'

Use title as placeholder instead of issue title for reusability

Closes gitlab-ee#3781

See merge request gitlab-org/gitlab-ce!14927
parents 81175d2c 59c03de5
...@@ -16,15 +16,15 @@ ...@@ -16,15 +16,15 @@
<fieldset> <fieldset>
<label <label
class="sr-only" class="sr-only"
for="issue-title"> for="issuable-title">
Title Title
</label> </label>
<input <input
id="issue-title" id="issuable-title"
class="form-control" class="form-control"
type="text" type="text"
placeholder="Issue title" placeholder="Title"
aria-label="Issue title" aria-label="Title"
v-model="formState.title" v-model="formState.title"
@keydown.meta.enter="updateIssuable" @keydown.meta.enter="updateIssuable"
@keydown.ctrl.enter="updateIssuable" /> @keydown.ctrl.enter="updateIssuable" />
......
---
title: Use title as placeholder instead of issue title for reusability
merge_request:
author:
type: other
...@@ -25,7 +25,7 @@ feature 'Issue Detail', :js do ...@@ -25,7 +25,7 @@ feature 'Issue Detail', :js do
wait_for_requests wait_for_requests
click_link 'Edit' click_link 'Edit'
fill_in 'issue-title', with: 'issue title' fill_in 'issuable-title', with: 'issue title'
click_button 'Save' click_button 'Save'
Users::DestroyService.new(user).execute(user) Users::DestroyService.new(user).execute(user)
......
...@@ -35,7 +35,7 @@ feature 'issuable templates', :js do ...@@ -35,7 +35,7 @@ feature 'issuable templates', :js do
page.within('.content .issuable-actions') do page.within('.content .issuable-actions') do
click_on 'Edit' click_on 'Edit'
end end
fill_in :'issue-title', with: 'test issue title' fill_in :'issuable-title', with: 'test issue title'
end end
scenario 'user selects "bug" template' do scenario 'user selects "bug" template' do
...@@ -80,7 +80,7 @@ feature 'issuable templates', :js do ...@@ -80,7 +80,7 @@ feature 'issuable templates', :js do
page.within('.content .issuable-actions') do page.within('.content .issuable-actions') do
click_on 'Edit' click_on 'Edit'
end end
fill_in :'issue-title', with: 'test issue title' fill_in :'issuable-title', with: 'test issue title'
fill_in :'issue-description', with: prior_description fill_in :'issue-description', with: prior_description
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment