Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
3c0872c2
Commit
3c0872c2
authored
Mar 29, 2021
by
drew cimino
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Updated changelog and removed flag specs
parent
f7092d82
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
69 deletions
+15
-69
changelogs/unreleased/fix-build-group-name.yml
changelogs/unreleased/fix-build-group-name.yml
+1
-1
spec/models/commit_status_spec.rb
spec/models/commit_status_spec.rb
+14
-68
No files found.
changelogs/unreleased/fix-build-group-name.yml
View file @
3c0872c2
+---
+title
:
Simplify Build Group name correction
+merge_request
:
+merge_request
:
57739
+author
:
+type
:
fixed
spec/models/commit_status_spec.rb
View file @
3c0872c2
...
...
@@ -511,35 +511,33 @@ RSpec.describe CommitStatus do
describe
'#group_name'
do
before
do
stub_feature_flags
(
simplified_commit_status_group_name:
fals
e
)
stub_feature_flags
(
simplified_commit_status_group_name:
tru
e
)
end
using
RSpec
::
Parameterized
::
TableSyntax
let
(
:commit_status
)
do
build
(
:commit_status
,
pipeline:
pipeline
,
stage:
'test'
)
end
subject
{
commit_status
.
group_name
}
where
(
:name
,
:group_name
)
do
'rspec1'
|
'rspec1'
'rspec1 0 1'
|
'rspec1'
'rspec1 0/2'
|
'rspec1'
'rspec:windows'
|
'rspec:windows'
'rspec:windows 0'
|
'rspec:windows 0'
'rspec:windows 0 2/2'
|
'rspec:windows 0'
'rspec:windows 0 test'
|
'rspec:windows 0 test'
'rspec:windows 0 1'
|
'rspec:windows'
'rspec:windows 0 1 name'
|
'rspec:windows name'
'rspec:windows 0 test 2/2'
|
'rspec:windows 0 test'
'rspec:windows 0 1 2/2'
|
'rspec:windows'
'rspec:windows 0 1 [aws] 2/2'
|
'rspec:windows'
'rspec:windows 0 1 name [aws] 2/2'
|
'rspec:windows 0 1 name'
'rspec:windows 0 1 name'
|
'rspec:windows 0 1 name'
'rspec:windows 0 1 name 1/2'
|
'rspec:windows 0 1 name'
'rspec:windows 0/1'
|
'rspec:windows'
'rspec:windows 0/1 name'
|
'rspec:windows name'
'rspec:windows 0/1 name'
|
'rspec:windows 0/1 name'
'rspec:windows 0/1 name 1/2'
|
'rspec:windows 0/1 name'
'rspec:windows 0:1'
|
'rspec:windows'
'rspec:windows 0:1 name'
|
'rspec:windows name'
'rspec:windows 0:1 name'
|
'rspec:windows
0:1
name'
'rspec:windows 10000 20000'
|
'rspec:windows'
'rspec:windows 0 : / 1'
|
'rspec:windows'
'rspec:windows 0 : / 1 name'
|
'rspec:windows name'
'0 1 name ruby'
|
'name ruby'
'0 :/ 1 name ruby'
|
'name ruby'
'rspec:windows 0 : / 1 name'
|
'rspec:windows
0 : / 1
name'
'0 1 name ruby'
|
'
0 1
name ruby'
'0 :/ 1 name ruby'
|
'
0 :/ 1
name ruby'
'rspec: [aws]'
|
'rspec'
'rspec: [aws] 0/1'
|
'rspec'
'rspec: [aws, max memory]'
|
'rspec'
...
...
@@ -561,58 +559,6 @@ RSpec.describe CommitStatus do
is_expected
.
to
eq
(
group_name
)
end
end
context
'with simplified_commit_status_group_name'
do
before
do
stub_feature_flags
(
simplified_commit_status_group_name:
true
)
end
where
(
:name
,
:group_name
)
do
'rspec1'
|
'rspec1'
'rspec1 0 1'
|
'rspec1'
'rspec1 0/2'
|
'rspec1'
'rspec:windows'
|
'rspec:windows'
'rspec:windows 0'
|
'rspec:windows 0'
'rspec:windows 0 2/2'
|
'rspec:windows 0'
'rspec:windows 0 test'
|
'rspec:windows 0 test'
'rspec:windows 0 test 2/2'
|
'rspec:windows 0 test'
'rspec:windows 0 1 2/2'
|
'rspec:windows'
'rspec:windows 0 1 [aws] 2/2'
|
'rspec:windows'
'rspec:windows 0 1 name [aws] 2/2'
|
'rspec:windows 0 1 name'
'rspec:windows 0 1 name'
|
'rspec:windows 0 1 name'
'rspec:windows 0 1 name 1/2'
|
'rspec:windows 0 1 name'
'rspec:windows 0/1'
|
'rspec:windows'
'rspec:windows 0/1 name'
|
'rspec:windows 0/1 name'
'rspec:windows 0/1 name 1/2'
|
'rspec:windows 0/1 name'
'rspec:windows 0:1'
|
'rspec:windows'
'rspec:windows 0:1 name'
|
'rspec:windows 0:1 name'
'rspec:windows 10000 20000'
|
'rspec:windows'
'rspec:windows 0 : / 1'
|
'rspec:windows'
'rspec:windows 0 : / 1 name'
|
'rspec:windows 0 : / 1 name'
'0 1 name ruby'
|
'0 1 name ruby'
'0 :/ 1 name ruby'
|
'0 :/ 1 name ruby'
'rspec: [aws]'
|
'rspec'
'rspec: [aws] 0/1'
|
'rspec'
'rspec: [aws, max memory]'
|
'rspec'
'rspec:linux: [aws, max memory, data]'
|
'rspec:linux'
'rspec: [inception: [something, other thing], value]'
|
'rspec'
'rspec:windows 0/1: [name, other]'
|
'rspec:windows'
'rspec:windows: [name, other] 0/1'
|
'rspec:windows'
'rspec:windows: [name, 0/1] 0/1'
|
'rspec:windows'
'rspec:windows: [0/1, name]'
|
'rspec:windows'
'rspec:windows: [, ]'
|
'rspec:windows'
'rspec:windows: [name]'
|
'rspec:windows'
'rspec:windows: [name,other]'
|
'rspec:windows'
end
with_them
do
it
"
#{
params
[
:name
]
}
puts in
#{
params
[
:group_name
]
}
"
do
commit_status
.
name
=
name
is_expected
.
to
eq
(
group_name
)
end
end
end
end
describe
'#detailed_status'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment