Commit 3c580c1a authored by Grzegorz Bizon's avatar Grzegorz Bizon

Move database each_batch helpers to dynamic model helpers

parent 2f0668be
# frozen_string_literal: true # frozen_string_literal: true
class CleanUpPendingBuildsTable < ActiveRecord::Migration[6.0] class CleanUpPendingBuildsTable < ActiveRecord::Migration[6.0]
include ::Gitlab::Database::MigrationHelpers include ::Gitlab::Database::DynamicModelHelpers
BATCH_SIZE = 1000 BATCH_SIZE = 1000
......
...@@ -11,6 +11,25 @@ module Gitlab ...@@ -11,6 +11,25 @@ module Gitlab
self.inheritance_column = :_type_disabled self.inheritance_column = :_type_disabled
end end
end end
def each_batch(table_name, scope: ->(table) { table.all }, of: 1000)
if transaction_open?
raise <<~MSG.squish
each_batch should not run inside a transaction, you can disable
transactions by calling disable_ddl_transaction! in the body of
your migration class
MSG
end
scope.call(define_batchable_model(table_name))
.each_batch(of: of) { |batch| yield batch }
end
def each_batch_range(table_name, scope: ->(table) { table.all }, of: 1000)
each_batch(table_name, scope: scope, of: of) do |batch|
yield batch.pluck('MIN(id), MAX(id)').first
end
end
end end
end end
end end
...@@ -1591,31 +1591,6 @@ into similar problems in the future (e.g. when new tables are created). ...@@ -1591,31 +1591,6 @@ into similar problems in the future (e.g. when new tables are created).
raise raise
end end
def each_batch(table_name, scope: ->(table) { table.all }, of: 1000)
if transaction_open?
raise <<~MSG.squish
each_batch should not run inside a transaction, you can disable
transactions by calling disable_ddl_transaction! in the body of
your migration class
MSG
end
table = Class.new(ActiveRecord::Base) do
include EachBatch
self.table_name = table_name
self.inheritance_column = :_type_disabled
end
scope.call(table).each_batch(of: of) { |batch| yield batch }
end
def each_batch_range(table_name, scope: ->(table) { table.all }, of: 1000)
each_batch(table_name, scope: scope, of: of) do |batch|
yield batch.pluck('MIN(id), MAX(id)').first
end
end
private private
def validate_check_constraint_name!(constraint_name) def validate_check_constraint_name!(constraint_name)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment