Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
3daea290
Commit
3daea290
authored
Apr 03, 2020
by
Dhiraj Bodicherla
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update doc strings for annotations file
parent
4aa0d391
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
17 additions
and
7 deletions
+17
-7
app/assets/javascripts/monitoring/components/charts/annotations.js
...s/javascripts/monitoring/components/charts/annotations.js
+17
-7
No files found.
app/assets/javascripts/monitoring/components/charts/annotations.js
View file @
3daea290
import
{
graphTypes
,
symbolSizes
}
from
'
../../constants
'
;
import
{
graphTypes
,
symbolSizes
}
from
'
../../constants
'
;
/**
/**
* A "virtual" coordinates system for the annotation series.
* Annotations and deployments are decoration layers on
* top of the actual chart data. We use a scatter plot to
* display this information. Each chart has its coordinate
* system based on data and irresptive of the data, these
* decorations have to be placed in specific locations.
* For this reason, annotations have their own coordinate system,
*
* As of %12.9, only deployment icons, a type of annotations, need
* to be displayed on the chart.
*
* After https://gitlab.com/gitlab-org/gitlab/-/issues/211418,
* annotations and deployments will co-exist in the same
* series as they logically belong together. Annotations will be
* passed as markLine objects.
*/
/**
* Deployment icons, a type of annotation, are displayed
* Deployment icons, a type of annotation, are displayed
* along the [min, max] range at height `pos`.
* along the [min, max] range at height `pos`.
*/
*/
...
@@ -35,12 +51,6 @@ export const annotationsYAxis = {
...
@@ -35,12 +51,6 @@ export const annotationsYAxis = {
export
const
isAnnotation
=
type
=>
type
===
graphTypes
.
annotationsData
;
export
const
isAnnotation
=
type
=>
type
===
graphTypes
.
annotationsData
;
/**
/**
* Annotations are scatter plot series that are passed
* to eCharts along with the actual data series. As of %12.9
* deployment icons, a type of annotations, need to be displayed on
* the chart and a scatter plot is the most convenient way.
*
*
* This method currently supports only deployments. After
* This method currently supports only deployments. After
* https://gitlab.com/gitlab-org/gitlab/-/issues/211418 annotations
* https://gitlab.com/gitlab-org/gitlab/-/issues/211418 annotations
* support will be added in this method.
* support will be added in this method.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment