Merge branch 'issue#325836-fix-empty-line-after-let-it-be-gitlab-imoport-export' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/import_export

See merge request gitlab-org/gitlab!58264

.rubocop_manual_todo.yml

@@ -811,14 +811,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/lib/gitlab/hook_data/issue_builder_spec.rb
     - spec/lib/gitlab/hook_data/merge_request_builder_spec.rb
     - spec/lib/gitlab/hook_data/release_builder_spec.rb
-    - spec/lib/gitlab/import_export/design_repo_saver_spec.rb
-    - spec/lib/gitlab/import_export/fast_hash_serializer_spec.rb
-    - spec/lib/gitlab/import_export/project/export_task_spec.rb
-    - spec/lib/gitlab/import_export/project/tree_saver_spec.rb
-    - spec/lib/gitlab/import_export/repo_saver_spec.rb
-    - spec/lib/gitlab/import_export/snippet_repo_saver_spec.rb
-    - spec/lib/gitlab/import_export/snippets_repo_saver_spec.rb
-    - spec/lib/gitlab/import_export/wiki_repo_saver_spec.rb
     - spec/lib/gitlab/jira_import/base_importer_spec.rb
     - spec/lib/gitlab/jira_import/handle_labels_service_spec.rb
     - spec/lib/gitlab/jira_import_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-gitlab-imoport-export.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe offenses spec/lib/gitlab/import_export
+merge_request: 58264
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/lib/gitlab/import_export/design_repo_saver_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Gitlab::ImportExport::DesignRepoSaver do
   describe 'bundle a design Git repo' do
     let_it_be(:user) { create(:user) }
     let_it_be(:design) { create(:design, :with_file, versions_count: 1) }
+
     let!(:project) { create(:project, :design_repo) }
     let(:export_path) { "#{Dir.tmpdir}/project_tree_saver_spec" }
     let(:shared) { project.import_export_shared }

spec/lib/gitlab/import_export/fast_hash_serializer_spec.rb

@@ -12,6 +12,7 @@ RSpec.describe Gitlab::ImportExport::FastHashSerializer do
 
   let_it_be(:user) { create(:user) }
   let_it_be(:project) { setup_project }
+
   let(:shared) { project.import_export_shared }
   let(:reader) { Gitlab::ImportExport::Reader.new(shared: shared) }
   let(:tree) { reader.project_tree }

spec/lib/gitlab/import_export/project/export_task_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Gitlab::ImportExport::Project::ExportTask do
   let_it_be(:username) { 'root' }
   let(:namespace_path) { username }
   let_it_be(:user) { create(:user, username: username) }
+
   let(:measurement_enabled) { false }
   let(:file_path) { 'spec/fixtures/gitlab/import_export/test_project_export.tar.gz' }
   let(:project) { create(:project, creator: user, namespace: user.namespace) }

spec/lib/gitlab/import_export/project/tree_saver_spec.rb

@@ -267,6 +267,7 @@ RSpec.describe Gitlab::ImportExport::Project::TreeSaver do
     describe '#saves project tree' do
       let_it_be(:user) { create(:user) }
       let_it_be(:group) { create(:group) }
+
       let(:project) { setup_project }
       let(:full_path) do
         if ndjson_enabled

spec/lib/gitlab/import_export/repo_saver_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe Gitlab::ImportExport::RepoSaver do
   describe 'bundle a project Git repo' do
     let_it_be(:user) { create(:user) }
+
     let!(:project) { create(:project, :repository) }
     let(:export_path) { "#{Dir.tmpdir}/project_tree_saver_spec" }
     let(:shared) { project.import_export_shared }

spec/lib/gitlab/import_export/snippet_repo_saver_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe Gitlab::ImportExport::SnippetRepoSaver do
     let_it_be(:user) { create(:user) }
     let_it_be(:project) { create(:project, namespace: user.namespace) }
     let_it_be(:snippet) { create(:project_snippet, :repository, project: project, author: user) }
+
     let(:shared) { project.import_export_shared }
     let(:bundler) { described_class.new(project: project, shared: shared, repository: snippet.repository) }
     let(:bundle_path) { ::Gitlab::ImportExport.snippets_repo_bundle_path(shared.export_path) }

spec/lib/gitlab/import_export/snippets_repo_saver_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe Gitlab::ImportExport::SnippetsRepoSaver do
   describe 'bundle a project Git repo' do
     let_it_be(:user) { create(:user) }
+
     let!(:project) { create(:project) }
     let(:shared) { project.import_export_shared }
     let(:bundler) { described_class.new(current_user: user, project: project, shared: shared) }

spec/lib/gitlab/import_export/wiki_repo_saver_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Gitlab::ImportExport::WikiRepoSaver do
   describe 'bundle a wiki Git repo' do
     let_it_be(:user) { create(:user) }
     let_it_be(:project) { create(:project, :wiki_repo) }
+
     let(:export_path) { "#{Dir.tmpdir}/project_tree_saver_spec" }
     let(:shared) { project.import_export_shared }
     let(:wiki_bundler) { described_class.new(exportable: project, shared: shared) }