Commit 429169a1 authored by Mike Greiling's avatar Mike Greiling Committed by Paul Slaughter

Replace empty placeholder diff row with colgroup

Removes the thin white gap at the top of the diff
code blocks which was added to preserve column sizes
when diff expansion rows would use `colspan` in the first row.

https://gitlab.com/gitlab-org/gitlab/merge_requests/17026
parent 792dc566
...@@ -45,12 +45,11 @@ export default { ...@@ -45,12 +45,11 @@ export default {
:data-commit-id="commitId" :data-commit-id="commitId"
class="code diff-wrap-lines js-syntax-highlight text-file js-diff-inline-view" class="code diff-wrap-lines js-syntax-highlight text-file js-diff-inline-view"
> >
<!-- Need to insert an empty row to solve "table-layout:fixed" equal width when expansion row is the first line --> <colgroup>
<tr> <col style="width: 50px;" />
<td style="width: 50px;"></td> <col style="width: 50px;" />
<td style="width: 50px;"></td> <col />
<td></td> </colgroup>
</tr>
<tbody> <tbody>
<template v-for="(line, index) in diffLines"> <template v-for="(line, index) in diffLines">
<inline-diff-expansion-row <inline-diff-expansion-row
......
...@@ -45,13 +45,12 @@ export default { ...@@ -45,13 +45,12 @@ export default {
:data-commit-id="commitId" :data-commit-id="commitId"
class="code diff-wrap-lines js-syntax-highlight text-file" class="code diff-wrap-lines js-syntax-highlight text-file"
> >
<!-- Need to insert an empty row to solve "table-layout:fixed" equal width when expansion row is the first line --> <colgroup>
<tr> <col style="width: 50px;" />
<td style="width: 50px;"></td> <col />
<td></td> <col style="width: 50px;" />
<td style="width: 50px;"></td> <col />
<td></td> </colgroup>
</tr>
<tbody> <tbody>
<template v-for="(line, index) in diffLines"> <template v-for="(line, index) in diffLines">
<parallel-diff-expansion-row <parallel-diff-expansion-row
......
---
title: Remove thin white line at top of diff view code blocks
merge_request: 17026
author:
type: fixed
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment