Commit 4402cdd5 authored by Clement Ho's avatar Clement Ho

Merge branch 'assignee-sidebar-tooltip-overlap' into 'master'

Fixed assignees tooltip clipping in sidebar

Closes gitlab-ce#32512

See merge request !1928
parents ae976e93 b943596e
...@@ -187,6 +187,7 @@ export default { ...@@ -187,6 +187,7 @@ export default {
> >
<a <a
class="user-link has-tooltip" class="user-link has-tooltip"
data-container="body"
data-placement="bottom" data-placement="bottom"
:href="assigneeUrl(user)" :href="assigneeUrl(user)"
:data-title="user.name" :data-title="user.name"
......
...@@ -187,6 +187,21 @@ describe('Assignee component', () => { ...@@ -187,6 +187,21 @@ describe('Assignee component', () => {
expect(component.$el.querySelector('.user-list-more')).toBe(null); expect(component.$el.querySelector('.user-list-more')).toBe(null);
}); });
it('sets tooltip container to body', () => {
const users = UsersMockHelper.createNumberRandomUsers(2);
component = new AssigneeComponent({
propsData: {
rootPath: 'http://localhost:3000',
users,
editable: true,
},
}).$mount();
expect(
component.$el.querySelector('.user-link').getAttribute('data-container'),
).toBe('body');
});
it('Shows the "show-less" assignees label', (done) => { it('Shows the "show-less" assignees label', (done) => {
const users = UsersMockHelper.createNumberRandomUsers(6); const users = UsersMockHelper.createNumberRandomUsers(6);
component = new AssigneeComponent({ component = new AssigneeComponent({
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment