Feedback: use mutation_types

app/assets/javascripts/whats_new/components/app.vue

@@ -10,7 +10,7 @@ export default {
     ...mapState(['open']),
   },
   methods: {
-    ...mapActions(['closeDrawer', 'openDrawer']),
+    ...mapActions(['closeDrawer']),
   },
 };
 </script>

app/assets/javascripts/whats_new/store/actions.js

+import * as types from './mutation_types';
+
 export default {
   closeDrawer({ commit }) {
-    commit('closeDrawer');
+    commit(types.CLOSE_DRAWER);
   },
   openDrawer({ commit }) {
-    commit('openDrawer');
+    commit(types.OPEN_DRAWER);
   },
 };

app/assets/javascripts/whats_new/store/mutation_types.js

+export const CLOSE_DRAWER = 'CLOSE_DRAWER';
+export const OPEN_DRAWER = 'OPEN_DRAWER';

app/assets/javascripts/whats_new/store/mutations.js

+import * as types from './mutation_types';
+
 export default {
-  closeDrawer(state) {
+  [types.CLOSE_DRAWER](state) {
     state.open = false;
   },
-  openDrawer(state) {
+  [types.OPEN_DRAWER](state) {
     state.open = true;
   },
 };

spec/frontend/whats_new/store/actions_spec.js

 import testAction from 'helpers/vuex_action_helper';
 import actions from '~/whats_new/store/actions';
+import * as types from '~/whats_new/store/mutation_types';
 
 describe('whats new actions', () => {
   describe('openDrawer', () => {
     it('should commit openDrawer', () => {
-      testAction(actions.openDrawer, {}, {}, [{ type: 'openDrawer' }]);
+      testAction(actions.openDrawer, {}, {}, [{ type: types.OPEN_DRAWER }]);
     });
   });
 
   describe('closeDrawer', () => {
     it('should commit closeDrawer', () => {
-      testAction(actions.closeDrawer, {}, {}, [{ type: 'closeDrawer' }]);
+      testAction(actions.closeDrawer, {}, {}, [{ type: types.CLOSE_DRAWER }]);
     });
   });
 });

spec/frontend/whats_new/store/mutations_spec.js

 import mutations from '~/whats_new/store/mutations';
 import createState from '~/whats_new/store/state';
+import * as types from '~/whats_new/store/mutation_types';
 
 describe('whats new mutations', () => {
   let state;
@@ -10,14 +11,14 @@ describe('whats new mutations', () => {
 
   describe('openDrawer', () => {
     it('sets open to true', () => {
-      mutations.openDrawer(state);
+      mutations[types.OPEN_DRAWER](state);
       expect(state.open).toBe(true);
     });
   });
 
   describe('closeDrawer', () => {
     it('sets open to false', () => {
-      mutations.closeDrawer(state);
+      mutations[types.CLOSE_DRAWER](state);
       expect(state.open).toBe(false);
     });
   });