Commit 454c8f25 authored by Kamil Trzciński's avatar Kamil Trzciński

Merge branch '217469-follow-up-from-fix-minutes-notification-when-unauthenticated' into 'master'

Allow developers to see ci minutes notifications

Closes #217469

See merge request gitlab-org/gitlab!31937
parents f3fd21a6 7cd20b91
...@@ -113,7 +113,6 @@ module EE ...@@ -113,7 +113,6 @@ module EE
enable :create_jira_connect_subscription enable :create_jira_connect_subscription
enable :maintainer_access enable :maintainer_access
enable :admin_wiki enable :admin_wiki
enable :read_ci_minutes_quota
end end
rule { owner }.policy do rule { owner }.policy do
...@@ -198,6 +197,7 @@ module EE ...@@ -198,6 +197,7 @@ module EE
rule { developer }.policy do rule { developer }.policy do
enable :create_wiki enable :create_wiki
enable :admin_merge_request enable :admin_merge_request
enable :read_ci_minutes_quota
end end
rule { security_dashboard_enabled & developer }.enable :read_group_security_dashboard rule { security_dashboard_enabled & developer }.enable :read_group_security_dashboard
......
---
title: Allow developers to see ci minutes notifications
merge_request: 31937
author:
type: changed
...@@ -53,7 +53,7 @@ describe Ci::Minutes::Context do ...@@ -53,7 +53,7 @@ describe Ci::Minutes::Context do
describe '#can_see_status' do describe '#can_see_status' do
context 'when eligible to see status' do context 'when eligible to see status' do
before do before do
group.add_owner(user) group.add_developer(user)
end end
it 'can see status' do it 'can see status' do
......
...@@ -128,7 +128,7 @@ describe Ci::Minutes::Notification do ...@@ -128,7 +128,7 @@ describe Ci::Minutes::Notification do
describe '#show?' do describe '#show?' do
context 'when eligible to see notifications' do context 'when eligible to see notifications' do
before do before do
group.add_owner(user) group.add_developer(user)
end end
context 'with a project that has runners enabled inside namespace' do context 'with a project that has runners enabled inside namespace' do
......
...@@ -1051,7 +1051,7 @@ describe GroupPolicy do ...@@ -1051,7 +1051,7 @@ describe GroupPolicy do
where(:role, :allowed) do where(:role, :allowed) do
:guest | false :guest | false
:reporter | false :reporter | false
:developer | false :developer | true
:maintainer | true :maintainer | true
:owner | true :owner | true
:admin | true :admin | true
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment