Commit 4688e137 authored by 🙈  jacopo beschi 🙉's avatar 🙈 jacopo beschi 🙉 Committed by Sean McGivern

Resolve "catch entering username as an email instead of returning a 500 error"

parent de30e044
- return unless @user.persisted?
= f.fields_for :namespace do |namespace_form| = f.fields_for :namespace do |namespace_form|
= namespace_form.hidden_field :id = namespace_form.hidden_field :id
%fieldset %fieldset
......
---
title: Fixes 500 error on user creation from admin panel with spaced username
merge_request: 6804
author: Jacopo Beschi @jacopo-beschi
type: fixed
...@@ -68,10 +68,12 @@ describe "Admin::Users" do ...@@ -68,10 +68,12 @@ describe "Admin::Users" do
end end
describe "GET /admin/users/new" do describe "GET /admin/users/new" do
let(:user_username) { 'bang' }
before do before do
visit new_admin_user_path visit new_admin_user_path
fill_in "user_name", with: "Big Bang" fill_in "user_name", with: "Big Bang"
fill_in "user_username", with: "bang" fill_in "user_username", with: user_username
fill_in "user_email", with: "bigbang@mail.com" fill_in "user_email", with: "bigbang@mail.com"
end end
...@@ -112,6 +114,17 @@ describe "Admin::Users" do ...@@ -112,6 +114,17 @@ describe "Admin::Users" do
expect(email.text_part.body).to have_content(user.email) expect(email.text_part.body).to have_content(user.email)
expect(email.text_part.body).to have_content('password') expect(email.text_part.body).to have_content('password')
end end
context 'username contains spaces' do
let(:user_username) { 'Bing bang' }
it "doesn't create the user and shows an error message" do
expect { click_button "Create user" }.to change {User.count}.by(0)
expect(page).to have_content('The form contains the following error')
expect(page).to have_content('Username can contain only letters, digits')
end
end
end end
describe "GET /admin/users/:id" do describe "GET /admin/users/:id" do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment