Make malformed danger blocks errors

Bump this up from warning to error.

doc/.vale/gitlab/AlertBoxDanger.yml

@@ -6,7 +6,7 @@
 # For a list of all options, see https://errata-ai.gitbook.io/vale/getting-started/styles
 extends: substitution
 message: "DANGER: alert boxes must be of the format 'DANGER: **Warning:**'. 'Warning' can be replaced with 'Important', 'Deprecated', or 'Required'."
-level: warning
+level: error
 nonword: true
 scope: raw
 swap:

doc/administration/geo/disaster_recovery/index.md

@@ -134,7 +134,7 @@ Note the following when promoting a secondary:
 
 1. Promote the **secondary** node to the **primary** node.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 In GitLab 13.2 and later versions, promoting a secondary node to a primary while the secondary is paused fails. We are [investigating the issue](https://gitlab.com/gitlab-org/gitlab/-/issues/225173). Do not pause replication before promoting a secondary. If the node is paused, please resume before promoting.
 
    To promote the secondary node to primary along with preflight checks:
@@ -166,7 +166,7 @@ conjunction with multiple servers, as it can only
 perform changes on a **secondary** with only a single machine. Instead, you must
 do this manually.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 In GitLab 13.2 and later versions, promoting a secondary node to a primary while the secondary is paused fails. We are [investigating the issue](https://gitlab.com/gitlab-org/gitlab/-/issues/225173). Do not pause replication before promoting a secondary. If the node is paused, please resume before promoting.
 
 1. SSH in to the database node in the **secondary** and trigger PostgreSQL to
@@ -211,7 +211,7 @@ an external PostgreSQL database, as it can only perform changes on a **secondary
 node with GitLab and the database on the same machine. As a result, a manual process is
 required:
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 In GitLab 13.2 and later versions, promoting a secondary node to a primary while the secondary is paused fails. We are [investigating the issue](https://gitlab.com/gitlab-org/gitlab/-/issues/225173). Do not pause replication before promoting a secondary. If the node is paused, please resume before promoting.
 
 1. Promote the replica database associated with the **secondary** site. This will

doc/administration/geo/disaster_recovery/runbooks/planned_failover_multi_node.md

@@ -227,7 +227,7 @@ conjunction with multiple servers, as it can only
 perform changes on a **secondary** with only a single machine. Instead, you must
 do this manually.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 In GitLab 13.2 and later versions, promoting a secondary node to a primary while the secondary is paused fails. We are [investigating the issue](https://gitlab.com/gitlab-org/gitlab/-/issues/225173). Do not pause replication before promoting a secondary. If the node is paused, please resume before promoting.
 
 1. SSH in to the PostgreSQL node in the **secondary** and trigger PostgreSQL to

doc/administration/geo/index.md

@@ -195,7 +195,7 @@ For information on how to update your Geo nodes to the latest GitLab version, se
 
 > [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/35913) in [GitLab Premium](https://about.gitlab.com/pricing/) 13.2.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 In GitLab 13.2 and later versions, promoting a secondary node to a primary while the secondary is paused fails. We are [investigating the issue](https://gitlab.com/gitlab-org/gitlab/-/issues/225173). Do not pause replication before promoting a secondary. If the node is paused, please resume before promoting.
 
 In some circumstances, like during [upgrades](replication/updating_the_geo_nodes.md) or a [planned failover](disaster_recovery/planned_failover.md), it is desirable to pause replication between the primary and secondary.

doc/administration/geo/replication/datatypes.md

@@ -157,7 +157,7 @@ To enable, such as for package file replication:
 Feature.enable(:geo_package_file_replication)
 ```
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 Features not on this list, or with **No** in the **Replicated** column,
 are not replicated on the **secondary** node. Failing over without manually
 replicating data from those features will cause the data to be **lost**.
@@ -168,7 +168,7 @@ successfully, you must replicate their data using some other means.
 |:---------------------------------------------------------------------------------------------------------------|:-----------------------------------------------------------------------------------|:----------------------------------------------------------|:-------------------------------------------------------------------------------------|:---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
 | [Application data in PostgreSQL](../../postgresql/index.md)                                                    | **Yes** (10.2)                                                                     | **Yes** (10.2)                                            | No                                                                                   |                                                                                                                                                                                                                                                                                                                            |
 | [Project repository](../../..//user/project/repository/)                                                       | **Yes** (10.2)                                                                     | **Yes** (10.7)                                            | No                                                                                   |                                                                                                                                                                                                                                                                                                                            |
-| [Project wiki repository](../../../user/project/wiki/)                                                         | **Yes** (10.2)                                                                     | **Yes** (10.7)                                            | No                                                                                   |       
+| [Project wiki repository](../../../user/project/wiki/)                                                         | **Yes** (10.2)                                                                     | **Yes** (10.7)                                            | No                                                                                   |
 | [Group wiki repository](../../../user/group/index.md#group-wikis)     | [No](https://gitlab.com/gitlab-org/gitlab/-/issues/208147)                                                                  | [No](https://gitlab.com/gitlab-org/gitlab/-/issues/208147)           | No                                                                                   |                                                                                                                                                                                                                                                                                                                                 |
 | [Uploads](../../uploads.md)                                                                                    | **Yes** (10.2)                                                                     | [No](https://gitlab.com/groups/gitlab-org/-/epics/1817)   | No                                                                                   | Verified only on transfer or manually using [Integrity Check Rake Task](../../raketasks/check.md) on both nodes and comparing the output between them.                                                                                                                                                                     |
 | [LFS objects](../../lfs/index.md)                                                                              | **Yes** (10.2)                                                                     | [No](https://gitlab.com/gitlab-org/gitlab/-/issues/8922)  | Via Object Storage provider if supported. Native Geo support (Beta).                 | Verified only on transfer or manually using [Integrity Check Rake Task](../../raketasks/check.md) on both nodes and comparing the output between them. GitLab versions 11.11.x and 12.0.x are affected by [a bug that prevents any new LFS objects from replicating](https://gitlab.com/gitlab-org/gitlab/-/issues/32696). |

doc/administration/geo/replication/updating_the_geo_nodes.md

@@ -21,7 +21,7 @@ Updating Geo nodes involves performing:
 NOTE: **Note:**
 These general update steps are not intended for [high-availability deployments](https://docs.gitlab.com/omnibus/update/README.html#multi-node--ha-deployment), and will cause downtime. If you want to avoid downtime, consider using [zero downtime updates](https://docs.gitlab.com/omnibus/update/README.html#zero-downtime-updates).
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 In GitLab 13.2 and later versions, promoting a secondary node to a primary while the secondary is paused fails. We are [investigating the issue](https://gitlab.com/gitlab-org/gitlab/-/issues/225173). Do not pause replication before promoting a secondary. If the node is paused, please resume before promoting.
 
 To update the Geo nodes when a new GitLab version is released, update **primary**

doc/administration/geo/replication/version_specific_updates.md

@@ -75,7 +75,7 @@ sudo touch /etc/gitlab/disable-postgresql-upgrade
 
 ## Updating to GitLab 12.7
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 Only upgrade to GitLab 12.7.5 or later. Do not upgrade to versions 12.7.0
 through 12.7.4 because there is [an initialization order
 bug](https://gitlab.com/gitlab-org/gitlab/-/issues/199672) that causes Geo
@@ -139,7 +139,7 @@ sudo touch /etc/gitlab/disable-postgresql-upgrade
 
 ## Updating to GitLab 12.3
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 If the existing PostgreSQL server version is 9.6.x, it is recommended to
 upgrade to GitLab 12.4 or newer. By default, GitLab 12.3 will attempt to
 automatically update the embedded PostgreSQL server to 10.9 from 9.6. In
@@ -155,7 +155,7 @@ for the recommended procedure.
 
 ## Updating to GitLab 12.2
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 If the existing PostgreSQL server version is 9.6.x, it is recommended to
 upgrade to GitLab 12.4 or newer. By default, GitLab 12.2 will attempt to
 automatically update the embedded PostgreSQL server to 10.9 from 9.6. In
@@ -187,7 +187,7 @@ The restart avoids a version mismatch when PostgreSQL tries to load the FDW exte
 
 ## Updating to GitLab 12.1
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 If the existing PostgreSQL server version is 9.6.x, it is recommended to
 upgrade to GitLab 12.4 or newer. By default, GitLab 12.1 will attempt to
 automatically update the embedded PostgreSQL server to 10.9 from 9.6. In

doc/administration/gitaly/index.md

@@ -121,7 +121,7 @@ The following list depicts the network architecture of Gitaly:
 - Authentication is done through a static token which is shared among the Gitaly and GitLab Rails
   nodes.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 Gitaly servers must not be exposed to the public internet as Gitaly's network traffic is unencrypted
 by default. The use of firewall is highly recommended to restrict access to the Gitaly server.
 Another option is to [use TLS](#enable-tls-support).
@@ -450,7 +450,7 @@ server (with `gitaly_address`) unless you setup with special
 When you tail the Gitaly logs on your Gitaly server, you should see requests coming in. One sure way
 to trigger a Gitaly request is to clone a repository from GitLab over HTTP or HTTPS.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 If you have [server hooks](../server_hooks.md) configured, either per repository or globally, you
 must move these to the Gitaly servers. If you have multiple Gitaly servers, copy your server hooks
 to all Gitaly servers.

doc/administration/job_artifacts.md

@@ -103,7 +103,7 @@ If you configure GitLab to store artifacts on object storage, you may also want
 [eliminate local disk usage for job logs](job_logs.md#prevent-local-disk-usage).
 In both cases, job logs are archived and moved to object storage when the job completes.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 In a multi-server setup you must use one of the options to
 [eliminate local disk usage for job logs](job_logs.md#prevent-local-disk-usage), or job logs could be lost.
 

doc/administration/job_logs.md

@@ -82,7 +82,7 @@ job output in the UI will be empty.
 
 For example, to delete all job logs older than 60 days, run the following from a shell in your GitLab instance:
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 This command will permanently delete the log files and is irreversible.
 
 ```shell

doc/administration/monitoring/performance/grafana_configuration.md

@@ -113,7 +113,7 @@ If you require access to your old Grafana data but don't meet one of these crite
 1. [Exporting the dashboards](https://grafana.com/docs/grafana/latest/reference/export_import/#exporting-a-dashboard) you need.
 1. Refreshing the data and [re-importing your dashboards](https://grafana.com/docs/grafana/latest/reference/export_import/#importing-a-dashboard).
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 These actions pose a temporary vulnerability while your old Grafana data is in use.
 Deciding to take any of these actions should be weighed carefully with your need to access
 existing data and dashboards.

doc/administration/operations/moving_repositories.md

@@ -15,7 +15,7 @@ We will look at three scenarios: the target directory is empty, the
 target directory contains an outdated copy of the repositories, and
 how to deal with thousands of repositories.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 Each of the approaches we list can/will overwrite data in the
 target directory `/mnt/gitlab/repositories`. Do not mix up the
 source and the target.

doc/administration/packages/container_registry.md

@@ -471,7 +471,7 @@ you can pull from the Container Registry, but you cannot push.
    [`--dryrun`](https://docs.aws.amazon.com/cli/latest/reference/s3/sync.html)
    flag and run the command.
 
-   DANGER: **Danger:**
+   DANGER: **Warning:**
    The [`--delete`](https://docs.aws.amazon.com/cli/latest/reference/s3/sync.html)
    flag deletes files that exist in the destination but not in the source.
    If you swap the source and destination, all data in the Registry is deleted.
@@ -823,7 +823,7 @@ understand the implications.
 
 > [Introduced](https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/3097) in Omnibus GitLab 11.10.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 This is a destructive operation.
 
 The GitLab Container Registry follows the same default workflow as Docker Distribution:

doc/administration/pages/index.md

@@ -514,7 +514,7 @@ your main application server.
 
 To configure GitLab Pages on a separate server:
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 The following procedure includes steps to back up and edit the
 `gitlab-secrets.json` file. This file contains secrets that control
 database encryption. Proceed with caution.

doc/administration/raketasks/maintenance.md

@@ -267,7 +267,7 @@ clear it.
 
 To clear all exclusive leases:
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 Don't run it while GitLab or Sidekiq is running
 
 ```shell

doc/administration/repository_storage_types.md

@@ -117,7 +117,7 @@ The output includes the project ID and the project name:
 
 > [Introduced](https://gitlab.com/gitlab-org/gitaly/-/issues/1606) in GitLab 12.1.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 Do not run `git prune` or `git gc` in pool repositories! This can
 cause data loss in "real" repositories that depend on the pool in
 question.

doc/ci/docker/using_docker_build.md

@@ -103,7 +103,7 @@ image in privileged mode.
 CI builds, follow the `docker-compose`
 [installation instructions](https://docs.docker.com/compose/install/).
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 By enabling `--docker-privileged`, you are effectively disabling all of
 the security mechanisms of containers and exposing your host to privilege
 escalation which can lead to container breakout. For more information, check

doc/ci/pipelines/job_artifacts.md

@@ -414,7 +414,7 @@ information in the UI.
 
 ## Erasing artifacts
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 This is a destructive action that leads to data loss. Use with caution.
 
 You can erase a single job via the UI, which also removes the job's

doc/ci/triggers/README.md

@@ -32,7 +32,7 @@ This also applies when using the `pipelines` or `triggers` keywords with the leg
 
 A unique trigger token can be obtained when [adding a new trigger](#adding-a-new-trigger).
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 Passing plain text tokens in public projects is a security issue. Potential
 attackers can impersonate the user that exposed their trigger token publicly in
 their `.gitlab-ci.yml` file. Use [variables](../variables/README.md#gitlab-cicd-environment-variables)

doc/development/chaos_endpoints.md

@@ -18,7 +18,7 @@ Currently, there are four endpoints for simulating the following conditions:
 For obvious reasons, these endpoints are not enabled by default on `production`.
 They are enabled by default on **development** environments.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 It is required that you secure access to the chaos endpoints using a secret token.
 You should not enable them in production unless you absolutely know what you're doing.
 

doc/development/contributing/index.md

@@ -37,7 +37,7 @@ Report suspected security vulnerabilities in private to
 `support@gitlab.com`, also see the
 [disclosure section on the GitLab.com website](https://about.gitlab.com/security/disclosure/).
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 Do **NOT** create publicly viewable issues for suspected security vulnerabilities.
 
 ## Code of conduct

doc/development/documentation/styleguide.md

@@ -1571,13 +1571,13 @@ This is something to be cautious about.
 ### Danger
 
 ```markdown
-DANGER: **Danger:**
+DANGER: **Warning:**
 This is a breaking change, a bug, or something very important to note.
 ```
 
 How it renders on the GitLab documentation site:
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 This is a breaking change, a bug, or something very important to note.
 
 ## Blockquotes

doc/development/fe_guide/icons.md

@@ -84,7 +84,7 @@ Please use the following function inside JS to render an icon:
 
 ### Usage in HAML/Rails
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 Do not use the `spinner` or `icon('spinner spin')` rails helpers to insert
 loading icons. These helpers rely on the Font Awesome icon library which is
 deprecated.

doc/development/git_object_deduplication.md

@@ -27,7 +27,7 @@ configuration. Objects in A that are not in B will remain in A. For this
 to work, it is of course critical that **no objects ever get deleted from
 B** because A might need them.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 Do not run `git prune` or `git gc` in pool repositories! This can
 cause data loss in "real" repositories that depend on the pool in
 question.

doc/gitlab-basics/command-line-commands.md

@@ -59,14 +59,14 @@ nano README.md
 
 It is easy to delete (remove) a file or directory, but be careful:
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 This will **permanently** delete a file.
 
 ```shell
 rm NAME-OF-FILE
 ```
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 This will **permanently** delete a directory and **all** of its contents.
 
 ```shell

doc/install/aws/index.md

@@ -312,7 +312,7 @@ We need a security group for our database that will allow inbound traffic from t
 
 ### Create the database
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 Avoid using burstable instances (t class instances) for the database as this could lead to performance issues due to CPU credits running out during sustained periods of high load.
 
 Now, it's time to create the database:

doc/integration/kerberos.md

@@ -164,7 +164,7 @@ GitLab users with a linked Kerberos account can also `git pull` and `git push`
 using Kerberos tokens, i.e., without having to send their password with each
 operation.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 There is a [known issue](https://github.com/curl/curl/issues/1261) with `libcurl`
 older than version 7.64.1 wherein it won't reuse connections when negotiating.
 This leads to authorization issues when push is larger than `http.postBuffer`

doc/raketasks/cleanup.md

@@ -6,7 +6,7 @@ GitLab provides Rake tasks for cleaning up GitLab instances.
 
 > [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/36628) in GitLab 12.10.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 Do not run this within 12 hours of a GitLab upgrade. This is to ensure that all background migrations
 have finished, which otherwise may lead to data loss.
 

doc/topics/autodevops/index.md

@@ -401,7 +401,7 @@ If you receive this error, you can do one of the following actions:
   database by setting `AUTO_DEVOPS_POSTGRES_DELETE_V1` to a non-empty value and
   redeploying.
 
-  DANGER: **Danger:**
+  DANGER: **Warning:**
   Deleting the channel 1 PostgreSQL database permanently deletes the existing
   channel 1 database and all its data. See
   [Upgrading PostgreSQL](upgrading_postgresql.md)
@@ -415,7 +415,7 @@ If you receive this error, you can do one of the following actions:
   and persisted by Helm, regardless of whether or not your chart uses the
   variable.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 Setting `POSTGRES_ENABLED` to `false` permanently deletes any existing
 channel 1 database for your environment.
 

doc/topics/autodevops/stages.md

@@ -285,7 +285,7 @@ see the documentation.
 To use a custom target instead of the auto-deployed review apps,
 set a `DAST_WEBSITE` environment variable to the URL for DAST to scan.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 If [DAST Full Scan](../../user/application_security/dast/index.md#full-scan) is
 enabled, GitLab strongly advises **not**
 to set `DAST_WEBSITE` to any staging or production environment. DAST Full Scan
@@ -428,7 +428,7 @@ To use Auto Deploy on a Kubernetes 1.16+ cluster:
 1. If you are deploying your application for the first time and are using
    GitLab 12.9 or 12.10, set `AUTO_DEVOPS_POSTGRES_CHANNEL` to `2`.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 On GitLab 12.9 and 12.10, opting into
 `AUTO_DEVOPS_POSTGRES_CHANNEL` version `2` deletes the version `1` PostgreSQL
 database. Follow the [guide to upgrading PostgreSQL](upgrading_postgresql.md)

doc/user/application_security/api_fuzzing/index.md

@@ -133,7 +133,7 @@ This is a minimal configuration for API Fuzzing. From here you can:
 - [Add authentication](#authentication).
 - Learn how to [handle false positives](#handling-false-positives).
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 **NEVER** run fuzz testing against a production server. Not only can it perform *any* function that
 the API can, it may also trigger bugs in the API. This includes actions like modifying and deleting
 data. Only run fuzzing against a test server.
@@ -224,7 +224,7 @@ This is a minimal configuration for API Fuzzing. From here you can:
 - [Add authentication](#authentication).
 - Learn how to [handle false positives](#handling-false-positives).
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 **NEVER** run fuzz testing against a production server. Not only can it perform *any* function that
 the API can, it may also trigger bugs in the API. This includes actions like modifying and deleting
 data. Only run fuzzing against a test server.

doc/user/application_security/dast/index.md

@@ -185,7 +185,7 @@ The results are saved as a
 that you can later download and analyze.
 Due to implementation limitations, we always take the latest DAST artifact available.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 **NEVER** run an authenticated scan against a production server. When an authenticated
 scan is run, it may perform *any* function that the authenticated user can. This
 includes actions like modifying and deleting data, submitting forms, and following links.

doc/user/profile/account/delete_account.md

@@ -35,7 +35,7 @@ As an administrator, you can delete a user account by:
    - **Delete user and contributions** to delete the user and
      their associated records.
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 Using the **Delete user and contributions** option may result
 in removing more data than intended. Please see [associated records](#associated-records)
 below for additional details.

doc/user/project/repository/reducing_the_repo_size_using_git.md

@@ -18,7 +18,7 @@ We **recommend [`git filter-repo`](https://github.com/newren/git-filter-repo/blo
 over [`git filter-branch`](https://git-scm.com/docs/git-filter-branch) and
 [BFG](https://rtyley.github.io/bfg-repo-cleaner/).
 
-DANGER: **Danger:**
+DANGER: **Warning:**
 Rewriting repository history is a destructive operation. Make sure to back up your repository before
 you begin. The best way back up a repository is to
 [export the project](../settings/import_export.md#exporting-a-project-and-its-data).

doc/user/project/service_desk.md

@@ -76,7 +76,7 @@ Follow these steps to do so:
    address's format. The older format is still supported, however, allowing existing aliases or
    contacts to continue working.
 
-   DANGER: **Danger:**
+   DANGER: **Warning:**
    This email address can be used by anyone to create an issue on this project, whether or not they
    have access to your GitLab instance. We recommend **putting this behind an alias** so it can be
    changed if needed, and **[enabling Akismet](../../integration/akismet.md)** on your GitLab