Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
4a23f3bd
Commit
4a23f3bd
authored
Jul 14, 2020
by
Arturo Herrero
Committed by
Imre Farkas
Jul 14, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix uninitialized constant testing integrations
parent
1b87f3ca
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
1 deletion
+6
-1
app/controllers/projects/services_controller.rb
app/controllers/projects/services_controller.rb
+1
-1
changelogs/unreleased/fix-uninitialized-constant.yml
changelogs/unreleased/fix-uninitialized-constant.yml
+5
-0
No files found.
app/controllers/projects/services_controller.rb
View file @
4a23f3bd
...
...
@@ -61,7 +61,7 @@ class Projects::ServicesController < Projects::ApplicationController
return
{
error:
true
,
message:
_
(
'Validations failed.'
),
service_response:
@service
.
errors
.
full_messages
.
join
(
','
),
test_failed:
false
}
end
result
=
Integrations
::
Test
::
ProjectService
.
new
(
@service
,
current_user
,
params
[
:event
]).
execute
result
=
::
Integrations
::
Test
::
ProjectService
.
new
(
@service
,
current_user
,
params
[
:event
]).
execute
unless
result
[
:success
]
return
{
error:
true
,
message:
_
(
'Test failed.'
),
service_response:
result
[
:message
].
to_s
,
test_failed:
true
}
...
...
changelogs/unreleased/fix-uninitialized-constant.yml
0 → 100644
View file @
4a23f3bd
---
title
:
Fix error message when saving an integration and testing the settings.
merge_request
:
36700
author
:
type
:
fixed
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment