Commit 4a536b06 authored by Rémy Coutable's avatar Rémy Coutable

Merge branch '209742-enable-telemetry-reviews-for-snowplow-events' into 'master'

Enable telemetry reviews for  snowplow events

Closes #209742

See merge request gitlab-org/gitlab!31208
parents 1a93abaa 5896c5f9
...@@ -9,12 +9,24 @@ USAGE_DATA_FILES_MESSAGE = <<~MSG ...@@ -9,12 +9,24 @@ USAGE_DATA_FILES_MESSAGE = <<~MSG
For the following files, a review from the [Data team and Telemetry team](https://gitlab.com/groups/gitlab-org/growth/telemetry/engineers/-/group_members?with_inherited_permissions=exclude) is recommended: For the following files, a review from the [Data team and Telemetry team](https://gitlab.com/groups/gitlab-org/growth/telemetry/engineers/-/group_members?with_inherited_permissions=exclude) is recommended:
MSG MSG
tracking_files = [
'lib/gitlab/tracking.rb',
'spec/lib/gitlab/tracking_spec.rb',
'app/helpers/tracking_helper.rb',
'spec/helpers/tracking_helper_spec.rb',
'app/assets/javascripts/tracking.js',
'spec/frontend/tracking_spec.js'
]
usage_data_changed_files = git.modified_files.grep(%r{usage_data}) usage_data_changed_files = git.modified_files.grep(%r{usage_data})
snowplow_events_changed_files = git.modified_files & tracking_files
changed_files = (usage_data_changed_files + snowplow_events_changed_files)
if usage_data_changed_files.any? if changed_files.any?
warn format(TELEMETRY_CHANGED_FILES_MESSAGE) warn format(TELEMETRY_CHANGED_FILES_MESSAGE)
markdown(USAGE_DATA_FILES_MESSAGE + helper.markdown_list(usage_data_changed_files)) markdown(USAGE_DATA_FILES_MESSAGE + helper.markdown_list(changed_files))
telemetry_labels = ['telemetry'] telemetry_labels = ['telemetry']
telemetry_labels << 'telemetry::review pending' unless helper.mr_has_labels?('telemetry::reviewed') telemetry_labels << 'telemetry::review pending' unless helper.mr_has_labels?('telemetry::reviewed')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment