Commit 4aaca884 authored by Fernando's avatar Fernando

Refactor security rule rows part I

* Move rows into seperate table
parent bb319f74
...@@ -165,6 +165,7 @@ export default { ...@@ -165,6 +165,7 @@ export default {
</script> </script>
<template> <template>
<div>
<rules :rules="rules"> <rules :rules="rules">
<template #thead="{ name, members, approvalsRequired, branches }"> <template #thead="{ name, members, approvalsRequired, branches }">
<tr class="d-none d-sm-table-row"> <tr class="d-none d-sm-table-row">
...@@ -204,9 +205,11 @@ export default { ...@@ -204,9 +205,11 @@ export default {
</td> </td>
</tr> </tr>
</template> </template>
</template>
</rules>
<!-- TODO: Remove feature flag in https://gitlab.com/gitlab-org/gitlab/-/issues/235114 --> <!-- TODO: Remove feature flag in https://gitlab.com/gitlab-org/gitlab/-/issues/235114 -->
<template v-if="glFeatures.approvalSuggestions"> <table class="table m-0" v-if="glFeatures.approvalSuggestions">
<tbody>
<unconfigured-security-rule <unconfigured-security-rule
v-for="securityRule in securityRules" v-for="securityRule in securityRules"
:key="securityRule.name" :key="securityRule.name"
...@@ -216,7 +219,7 @@ export default { ...@@ -216,7 +219,7 @@ export default {
:match-rule="securityRule" :match-rule="securityRule"
@enable="openCreateModal({ defaultRuleName: securityRule.name })" @enable="openCreateModal({ defaultRuleName: securityRule.name })"
/> />
</template> </tbody>
</template> </table>
</rules> </div>
</template> </template>
...@@ -94,7 +94,7 @@ export default { ...@@ -94,7 +94,7 @@ export default {
</td> </td>
</template> </template>
<td v-else class="js-name" colspan="3"> <td v-else class="js-name" colspan="5">
<div>{{ matchRule.name }}</div> <div>{{ matchRule.name }}</div>
<div class="gl-text-gray-500"> <div class="gl-text-gray-500">
<gl-sprintf :message="matchRule.description"> <gl-sprintf :message="matchRule.description">
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment