Commit 4bbbee41 authored by Abdul Wadood's avatar Abdul Wadood

Fix RSpec/EmptyLineAfterFinalLetItBe for status_page services

Contributes to https://gitlab.com/gitlab-org/gitlab/-/issues/325836
parent c4a90367
...@@ -592,12 +592,6 @@ RSpec/EmptyLineAfterFinalLetItBe: ...@@ -592,12 +592,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
- ee/spec/services/requirements_management/update_requirement_service_spec.rb - ee/spec/services/requirements_management/update_requirement_service_spec.rb
- ee/spec/services/resource_access_tokens/create_service_spec.rb - ee/spec/services/resource_access_tokens/create_service_spec.rb
- ee/spec/services/resource_access_tokens/revoke_service_spec.rb - ee/spec/services/resource_access_tokens/revoke_service_spec.rb
- ee/spec/services/status_page/publish_attachments_service_spec.rb
- ee/spec/services/status_page/publish_details_service_spec.rb
- ee/spec/services/status_page/publish_list_service_spec.rb
- ee/spec/services/status_page/publish_service_spec.rb
- ee/spec/services/status_page/trigger_publish_service_spec.rb
- ee/spec/services/status_page/unpublish_details_service_spec.rb
- ee/spec/services/todo_service_spec.rb - ee/spec/services/todo_service_spec.rb
- ee/spec/support/shared_examples/graphql/geo/geo_registries_resolver_shared_examples.rb - ee/spec/support/shared_examples/graphql/geo/geo_registries_resolver_shared_examples.rb
- ee/spec/support/shared_examples/graphql/mutations/set_multiple_assignees_shared_examples.rb - ee/spec/support/shared_examples/graphql/mutations/set_multiple_assignees_shared_examples.rb
......
...@@ -14,6 +14,7 @@ RSpec.describe StatusPage::PublishAttachmentsService do ...@@ -14,6 +14,7 @@ RSpec.describe StatusPage::PublishAttachmentsService do
describe '#execute' do describe '#execute' do
let_it_be(:project, refind: true) { create(:project) } let_it_be(:project, refind: true) { create(:project) }
let(:markdown_field) { 'Hello World' } let(:markdown_field) { 'Hello World' }
let(:user_notes) { [] } let(:user_notes) { [] }
let(:incident_id) { 1 } let(:incident_id) { 1 }
......
...@@ -6,6 +6,7 @@ RSpec.describe StatusPage::PublishDetailsService do ...@@ -6,6 +6,7 @@ RSpec.describe StatusPage::PublishDetailsService do
include ::StatusPage::PublicationServiceResponses include ::StatusPage::PublicationServiceResponses
let_it_be(:project, refind: true) { create(:project) } let_it_be(:project, refind: true) { create(:project) }
let(:user_notes) { [] } let(:user_notes) { [] }
let(:incident_id) { 1 } let(:incident_id) { 1 }
let(:issue) { instance_double(Issue, notes: user_notes, description: 'Incident Occuring', iid: incident_id) } let(:issue) { instance_double(Issue, notes: user_notes, description: 'Incident Occuring', iid: incident_id) }
......
...@@ -4,6 +4,7 @@ require 'spec_helper' ...@@ -4,6 +4,7 @@ require 'spec_helper'
RSpec.describe StatusPage::PublishListService do RSpec.describe StatusPage::PublishListService do
let_it_be(:project, refind: true) { create(:project) } let_it_be(:project, refind: true) { create(:project) }
let(:issues) { [instance_double(Issue)] } let(:issues) { [instance_double(Issue)] }
let(:key) { Gitlab::StatusPage::Storage.list_path } let(:key) { Gitlab::StatusPage::Storage.list_path }
let(:content) { [{ some: :content }] } let(:content) { [{ some: :content }] }
......
...@@ -7,6 +7,7 @@ RSpec.describe StatusPage::PublishService do ...@@ -7,6 +7,7 @@ RSpec.describe StatusPage::PublishService do
let_it_be(:project, refind: true) { create(:project) } let_it_be(:project, refind: true) { create(:project) }
let_it_be(:issue) { create(:issue, :published, project: project) } let_it_be(:issue) { create(:issue, :published, project: project) }
let_it_be(:settings) { create(:status_page_setting, :enabled, project: project) } let_it_be(:settings) { create(:status_page_setting, :enabled, project: project) }
let(:user_can_publish) { true } let(:user_can_publish) { true }
let(:service) do let(:service) do
......
...@@ -30,6 +30,7 @@ RSpec.describe StatusPage::TriggerPublishService do ...@@ -30,6 +30,7 @@ RSpec.describe StatusPage::TriggerPublishService do
describe 'triggered by issue' do describe 'triggered by issue' do
let_it_be(:triggered_by, reload: true) { create(:issue, :published, project: project) } let_it_be(:triggered_by, reload: true) { create(:issue, :published, project: project) }
let(:issue_id) { triggered_by.id } let(:issue_id) { triggered_by.id }
using RSpec::Parameterized::TableSyntax using RSpec::Parameterized::TableSyntax
...@@ -230,6 +231,7 @@ RSpec.describe StatusPage::TriggerPublishService do ...@@ -230,6 +231,7 @@ RSpec.describe StatusPage::TriggerPublishService do
context 'with eligable triggered_by' do context 'with eligable triggered_by' do
let_it_be(:triggered_by) { create(:issue, :published, project: project) } let_it_be(:triggered_by) { create(:issue, :published, project: project) }
let(:issue_id) { triggered_by.id } let(:issue_id) { triggered_by.id }
context 'when eligable' do context 'when eligable' do
......
...@@ -4,6 +4,7 @@ require 'spec_helper' ...@@ -4,6 +4,7 @@ require 'spec_helper'
RSpec.describe StatusPage::UnpublishDetailsService do RSpec.describe StatusPage::UnpublishDetailsService do
let_it_be(:project, refind: true) { create(:project) } let_it_be(:project, refind: true) { create(:project) }
let(:issue) { instance_double(Issue, iid: incident_id) } let(:issue) { instance_double(Issue, iid: incident_id) }
let(:incident_id) { 1 } let(:incident_id) { 1 }
let(:key) { Gitlab::StatusPage::Storage.details_path(incident_id) } let(:key) { Gitlab::StatusPage::Storage.details_path(incident_id) }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment