Commit 4d5ab72d authored by Rémy Coutable's avatar Rémy Coutable

Improve RuboCop config and fix documentation after review

Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
parent a3daceab
...@@ -10,10 +10,9 @@ AllCops: ...@@ -10,10 +10,9 @@ AllCops:
Exclude: Exclude:
- 'vendor/**/*' - 'vendor/**/*'
- 'node_modules/**/*' - 'node_modules/**/*'
- 'db/*' - 'db/**/*'
- 'db/fixtures/**/*' - 'db/fixtures/**/*'
- 'db/geo/*' - 'ee/db/**/*'
- 'ee/db/geo/*'
- 'tmp/**/*' - 'tmp/**/*'
- 'bin/**/*' - 'bin/**/*'
- 'generator_templates/**/*' - 'generator_templates/**/*'
...@@ -27,7 +26,6 @@ Style/MutableConstant: ...@@ -27,7 +26,6 @@ Style/MutableConstant:
Exclude: Exclude:
- 'db/migrate/**/*' - 'db/migrate/**/*'
- 'db/post_migrate/**/*' - 'db/post_migrate/**/*'
- 'db/geo/migrate/**/*'
- 'ee/db/migrate/**/*' - 'ee/db/migrate/**/*'
- 'ee/db/post_migrate/**/*' - 'ee/db/post_migrate/**/*'
- 'ee/db/geo/migrate/**/*' - 'ee/db/geo/migrate/**/*'
...@@ -52,10 +50,10 @@ GitlabSecurity/PublicSend: ...@@ -52,10 +50,10 @@ GitlabSecurity/PublicSend:
Exclude: Exclude:
- 'config/**/*' - 'config/**/*'
- 'db/**/*' - 'db/**/*'
- 'ee/db/**/*'
- 'features/**/*' - 'features/**/*'
- 'lib/**/*.rake' - 'lib/**/*.rake'
- 'ee/lib/**/*.rake'
- 'qa/**/*' - 'qa/**/*'
- 'spec/**/*' - 'spec/**/*'
- 'ee/db/**/*'
- 'ee/lib/**/*.rake'
- 'ee/spec/**/*' - 'ee/spec/**/*'
...@@ -28,8 +28,8 @@ we still need to merge changes from GitLab CE to EE. To help us get there, ...@@ -28,8 +28,8 @@ we still need to merge changes from GitLab CE to EE. To help us get there,
we should make sure that we no longer edit CE files in place in order to we should make sure that we no longer edit CE files in place in order to
implement EE features. implement EE features.
Instead, all EE codes should be put inside the `ee/` top-level directory. The Instead, all EE code should be put inside the `ee/` top-level directory. The
rest of codes should be as close as to the CE files. rest of the code should be as close to the CE files as possible.
[single code base]: https://gitlab.com/gitlab-org/gitlab-ee/issues/2952#note_41016454 [single code base]: https://gitlab.com/gitlab-org/gitlab-ee/issues/2952#note_41016454
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment