Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
4e6ac836
Commit
4e6ac836
authored
Jan 28, 2021
by
Donald Cook
Committed by
Illya Klymov
Jan 28, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Missing action prop on group page
parent
bbf4dfea
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
27 additions
and
1 deletion
+27
-1
app/assets/javascripts/groups/components/group_item.vue
app/assets/javascripts/groups/components/group_item.vue
+6
-1
changelogs/unreleased/296521-leave-this-group-button-not-working.yml
...unreleased/296521-leave-this-group-button-not-working.yml
+5
-0
spec/frontend/groups/components/item_actions_spec.js
spec/frontend/groups/components/item_actions_spec.js
+16
-0
No files found.
app/assets/javascripts/groups/components/group_item.vue
View file @
4e6ac836
...
...
@@ -179,7 +179,12 @@ export default {
<div
class=
"metadata align-items-md-center d-flex flex-grow-1 flex-shrink-0 flex-wrap justify-content-md-between"
>
<item-actions
v-if=
"isGroup"
:group=
"group"
:parent-group=
"parentGroup"
/>
<item-actions
v-if=
"isGroup"
:group=
"group"
:parent-group=
"parentGroup"
:action=
"action"
/>
<item-stats
:item=
"group"
class=
"group-stats gl-mt-2 d-none d-md-flex"
/>
</div>
</div>
...
...
changelogs/unreleased/296521-leave-this-group-button-not-working.yml
0 → 100644
View file @
4e6ac836
---
title
:
Missing action prop on group page
merge_request
:
52379
author
:
type
:
fixed
spec/frontend/groups/components/item_actions_spec.js
View file @
4e6ac836
...
...
@@ -66,6 +66,22 @@ describe('ItemActions', () => {
});
});
it
(
'
emits `showLeaveGroupModal` event with the correct prefix if `action` prop is passed
'
,
()
=>
{
const
group
=
{
...
mockParentGroupItem
,
canEdit
:
true
,
canLeave
:
true
,
};
createComponent
({
group
,
action
:
'
test
'
,
});
jest
.
spyOn
(
eventHub
,
'
$emit
'
);
findLeaveGroupBtn
().
vm
.
$emit
(
'
click
'
,
{
stopPropagation
:
()
=>
{}
});
expect
(
eventHub
.
$emit
).
toHaveBeenCalledWith
(
'
testshowLeaveGroupModal
'
,
group
,
parentGroup
);
});
it
(
'
does not render leave button if group can not be left
'
,
()
=>
{
createComponent
({
group
:
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment