Merge branch 'ajk-graphql-global-id-issue-move-list' into 'master'

Fix Rubocop violations in the issue-move-list mutation See merge request gitlab-org/gitlab!55610

Merge branch 'ajk-graphql-global-id-issue-move-list' into 'master'
Fix Rubocop violations in the issue-move-list mutation See merge request gitlab-org/gitlab!55610
50a24009 · Vitali Tatarintev · 01d7654b · c51c7ec2 · 50a24009
Commit 50a24009 authored Mar 03, 2021 by Vitali Tatarintev
Hide whitespace changes
Inline Side-by-side

Showing with 23 additions and 20 deletions

app/graphql/mutations/boards/issues/issue_move_list.rb app/graphql/mutations/boards/issues/issue_move_list.rb +23 -20

No files found.
--- a/app/graphql/mutations/boards/issues/issue_move_list.rb
+++ b/app/graphql/mutations/boards/issues/issue_move_list.rb
@@ -5,35 +5,38 @@ module Mutations
    module Issues
      class IssueMoveList < Mutations::Issues::Base
        graphql_name 'IssueMoveList'
+        BoardGID = ::Types::GlobalIDType[::Board]
+        ListID = ::GraphQL::ID_TYPE
+        IssueID = ::GraphQL::ID_TYPE
-        argument :board_id, GraphQL::ID_TYPE,
+        argument :board_id, BoardGID,
-                  required: true,
+                 required: true,
-                  loads: Types::BoardType,
+                 loads: Types::BoardType,
-                  description: 'Global ID of the board that the issue is in.'
+                 description: 'Global ID of the board that the issue is in.'
        argument :project_path, GraphQL::ID_TYPE,
-                  required: true,
+                 required: true,
-                  description: 'Project the issue to mutate is in.'
+                 description: 'Project the issue to mutate is in.'
        argument :iid, GraphQL::STRING_TYPE,
-                  required: true,
+                 required: true,
-                  description: 'IID of the issue to mutate.'
+                 description: 'IID of the issue to mutate.'
-        argument :from_list_id, GraphQL::ID_TYPE,
+        argument :from_list_id, ListID,
-                  required: false,
+                 required: false,
-                  description: 'ID of the board list that the issue will be moved from.'
+                 description: 'ID of the board list that the issue will be moved from.'
-        argument :to_list_id, GraphQL::ID_TYPE,
+        argument :to_list_id, ListID,
-                  required: false,
+                 required: false,
-                  description: 'ID of the board list that the issue will be moved to.'
+                 description: 'ID of the board list that the issue will be moved to.'
-        argument :move_before_id, GraphQL::ID_TYPE,
+        argument :move_before_id, IssueID,
-                  required: false,
+                 required: false,
-                  description: 'ID of issue that should be placed before the current issue.'
+                 description: 'ID of issue that should be placed before the current issue.'
-        argument :move_after_id, GraphQL::ID_TYPE,
+        argument :move_after_id, IssueID,
-                  required: false,
+                 required: false,
-                  description: 'ID of issue that should be placed after the current issue.'
+                 description: 'ID of issue that should be placed after the current issue.'
        def ready?(**args)
          if move_arguments(args).blank?