Commit 52000a69 authored by Jan Provaznik's avatar Jan Provaznik

Merge branch 'improve-rubocop-offence-message-for-large-tables' into 'master'

Improve Rubocop offense message

See merge request gitlab-org/gitlab!39805
parents 6b887cc3 20f38522
...@@ -13,7 +13,7 @@ module RuboCop ...@@ -13,7 +13,7 @@ module RuboCop
# distinct_count(Ci::Build, :commit_id) # distinct_count(Ci::Build, :commit_id)
# #
class DistinctCountByLargeForeignKey < RuboCop::Cop::Cop class DistinctCountByLargeForeignKey < RuboCop::Cop::Cop
MSG = 'Avoid doing `%s` for large foreign keys.'.freeze MSG = 'Avoid doing `%s` on foreign keys for large tables having above 100 million rows.'.freeze
def_node_matcher :distinct_count?, <<-PATTERN def_node_matcher :distinct_count?, <<-PATTERN
(send _ $:distinct_count $...) (send _ $:distinct_count $...)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment