Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
52843a07
Commit
52843a07
authored
Nov 20, 2020
by
Jake Lear
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add type=button to issue type selector to prevent premature submission
parent
945cc9c5
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
1 deletion
+7
-1
app/views/shared/issuable/form/_type_selector.html.haml
app/views/shared/issuable/form/_type_selector.html.haml
+1
-1
changelogs/unreleased/273580-when-selecting-issue-type-and-closing-the-dropdown-the-issue-gets-.yml
...g-issue-type-and-closing-the-dropdown-the-issue-gets-.yml
+6
-0
No files found.
app/views/shared/issuable/form/_type_selector.html.haml
View file @
52843a07
...
...
@@ -13,7 +13,7 @@
.dropdown-title.gl-display-flex
%span
.gl-ml-auto
=
_
(
"Select type"
)
%button
.dropdown-title-button.dropdown-menu-close.gl-ml-auto
{
"aria-label"
=>
_
(
'Close'
)
}
%button
.dropdown-title-button.dropdown-menu-close.gl-ml-auto
{
type:
'button'
,
"aria-label"
=>
_
(
'Close'
)
}
=
sprite_icon
(
'close'
,
size:
16
,
css_class:
'dropdown-menu-close-icon'
)
.dropdown-content
%ul
...
...
changelogs/unreleased/273580-when-selecting-issue-type-and-closing-the-dropdown-the-issue-gets-.yml
0 → 100644
View file @
52843a07
---
title
:
Adds type="button" to the close button for the issue type selector to prevent
accidental form submission
merge_request
:
48249
author
:
type
:
fixed
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment