Merge branch 'ce-to-ee-2018-10-03' into 'master'

CE upstream - 2018-10-03 00:21 UTC

See merge request gitlab-org/gitlab-ee!7777

app/assets/stylesheets/framework/modal.scss

@@ -19,6 +19,17 @@
     }
   }
 
+  // leave enough space for the close icon
+  .modal-title {
+    &.mw-100,
+    &.w-100 {
+      // after upgrading to Bootstrap 4.2 we can use $modal-header-padding-x here
+      // https://github.com/twbs/bootstrap/pull/26976
+      margin-right: -2rem;
+      padding-right: 2rem;
+    }
+  }
+
   .page-title {
     margin-top: 0;
   }

changelogs/unreleased/feature-flags-mvc.yml

+---
+title: Avoid close icon leaving the modal header
+merge_request: 21904
+author:
+type: changed