Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
534f10fd
Commit
534f10fd
authored
Mar 20, 2020
by
Alper Akgun
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Rename constants for batch counter batch sizes
Fixes the typo by renaming the constant names
parent
674f7bc5
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
3 deletions
+3
-3
lib/gitlab/database/batch_count.rb
lib/gitlab/database/batch_count.rb
+3
-3
No files found.
lib/gitlab/database/batch_count.rb
View file @
534f10fd
...
@@ -32,8 +32,8 @@ module Gitlab
...
@@ -32,8 +32,8 @@ module Gitlab
MAX_ALLOWED_LOOPS
=
10_000
MAX_ALLOWED_LOOPS
=
10_000
SLEEP_TIME_IN_SECONDS
=
0.01
# 10 msec sleep
SLEEP_TIME_IN_SECONDS
=
0.01
# 10 msec sleep
# Each query should take <<500ms https://gitlab.com/gitlab-org/gitlab/-/merge_requests/22705
# Each query should take <<500ms https://gitlab.com/gitlab-org/gitlab/-/merge_requests/22705
DEFAULT_DISTINCT_BATCH_SIZE
=
10
0
_000
DEFAULT_DISTINCT_BATCH_SIZE
=
10_000
DEFAULT_BATCH_SIZE
=
10_000
DEFAULT_BATCH_SIZE
=
10
0
_000
def
initialize
(
relation
,
column:
nil
)
def
initialize
(
relation
,
column:
nil
)
@relation
=
relation
@relation
=
relation
...
@@ -51,7 +51,7 @@ module Gitlab
...
@@ -51,7 +51,7 @@ module Gitlab
raise
"The mode
#{
mode
.
inspect
}
is not supported"
unless
[
:itself
,
:distinct
].
include?
(
mode
)
raise
"The mode
#{
mode
.
inspect
}
is not supported"
unless
[
:itself
,
:distinct
].
include?
(
mode
)
# non-distinct have better performance
# non-distinct have better performance
batch_size
||=
mode
==
:distinct
?
DEFAULT_
BATCH_SIZE
:
DEFAULT_DISTINC
T_BATCH_SIZE
batch_size
||=
mode
==
:distinct
?
DEFAULT_
DISTINCT_BATCH_SIZE
:
DEFAUL
T_BATCH_SIZE
start
=
@relation
.
minimum
(
@column
)
||
0
start
=
@relation
.
minimum
(
@column
)
||
0
finish
=
@relation
.
maximum
(
@column
)
||
0
finish
=
@relation
.
maximum
(
@column
)
||
0
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment