Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
536ded0c
Commit
536ded0c
authored
Nov 11, 2020
by
Arturo Herrero
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Feature flag group_level_integrations default enabled
This reverts commit
30815dc8
.
parent
58735e25
Changes
6
Show whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
10 additions
and
5 deletions
+10
-5
app/controllers/groups/settings/integrations_controller.rb
app/controllers/groups/settings/integrations_controller.rb
+1
-1
app/helpers/services_helper.rb
app/helpers/services_helper.rb
+1
-1
app/services/admin/propagate_integration_service.rb
app/services/admin/propagate_integration_service.rb
+1
-1
app/services/groups/create_service.rb
app/services/groups/create_service.rb
+1
-1
changelogs/unreleased/group-level-integration-feature-flag-default-enable.yml
...d/group-level-integration-feature-flag-default-enable.yml
+5
-0
config/feature_flags/development/group_level_integrations.yml
...ig/feature_flags/development/group_level_integrations.yml
+1
-1
No files found.
app/controllers/groups/settings/integrations_controller.rb
View file @
536ded0c
...
...
@@ -26,7 +26,7 @@ module Groups
end
def
integrations_enabled?
Feature
.
enabled?
(
:group_level_integrations
,
group
)
Feature
.
enabled?
(
:group_level_integrations
,
group
,
default_enabled:
true
)
end
def
scoped_edit_integration_path
(
integration
)
...
...
app/helpers/services_helper.rb
View file @
536ded0c
...
...
@@ -114,7 +114,7 @@ module ServicesHelper
end
def
group_level_integrations?
@group
.
present?
&&
Feature
.
enabled?
(
:group_level_integrations
,
@group
)
@group
.
present?
&&
Feature
.
enabled?
(
:group_level_integrations
,
@group
,
default_enabled:
true
)
end
def
instance_level_integrations?
...
...
app/services/admin/propagate_integration_service.rb
View file @
536ded0c
...
...
@@ -7,7 +7,7 @@ module Admin
def
propagate
if
integration
.
instance?
update_inherited_integrations
create_integration_for_groups_without_integration
if
Feature
.
enabled?
(
:group_level_integrations
)
create_integration_for_groups_without_integration
if
Feature
.
enabled?
(
:group_level_integrations
,
default_enabled:
true
)
create_integration_for_projects_without_integration
else
update_inherited_descendant_integrations
...
...
app/services/groups/create_service.rb
View file @
536ded0c
...
...
@@ -34,7 +34,7 @@ module Groups
if
@group
.
save
@group
.
add_owner
(
current_user
)
@group
.
create_namespace_settings
Service
.
create_from_active_default_integrations
(
@group
,
:group_id
)
if
Feature
.
enabled?
(
:group_level_integrations
)
Service
.
create_from_active_default_integrations
(
@group
,
:group_id
)
if
Feature
.
enabled?
(
:group_level_integrations
,
default_enabled:
true
)
end
end
...
...
changelogs/unreleased/group-level-integration-feature-flag-default-enable.yml
0 → 100644
View file @
536ded0c
---
title
:
Add group-level integration management for external services.
merge_request
:
47391
author
:
type
:
added
config/feature_flags/development/group_level_integrations.yml
View file @
536ded0c
...
...
@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/238575
milestone
:
'
12.10'
type
:
development
group
:
group::ecosystem
default_enabled
:
fals
e
default_enabled
:
tru
e
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment