Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
538ece0f
Commit
538ece0f
authored
Feb 17, 2020
by
Jacopo
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Replace underscore with lodash for ./app/assets/javascripts/mirrors
parent
98272880
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
9 additions
and
4 deletions
+9
-4
app/assets/javascripts/mirrors/mirror_repos.js
app/assets/javascripts/mirrors/mirror_repos.js
+2
-2
app/assets/javascripts/mirrors/ssh_mirror.js
app/assets/javascripts/mirrors/ssh_mirror.js
+2
-2
changelogs/unreleased/196660-replace-underscore-with-lodash-for-app-assets-javascripts-mirrors.yml
...rscore-with-lodash-for-app-assets-javascripts-mirrors.yml
+5
-0
No files found.
app/assets/javascripts/mirrors/mirror_repos.js
View file @
538ece0f
import
$
from
'
jquery
'
;
import
_
from
'
underscore
'
;
import
{
debounce
}
from
'
lodash
'
;
import
{
__
}
from
'
~/locale
'
;
import
Flash
from
'
~/flash
'
;
import
axios
from
'
~/lib/utils/axios_utils
'
;
...
...
@@ -62,7 +62,7 @@ export default class MirrorRepos {
}
registerUpdateListeners
()
{
this
.
debouncedUpdateUrl
=
_
.
debounce
(()
=>
this
.
updateUrl
(),
200
);
this
.
debouncedUpdateUrl
=
debounce
(()
=>
this
.
updateUrl
(),
200
);
this
.
$urlInput
.
on
(
'
input
'
,
()
=>
this
.
debouncedUpdateUrl
());
this
.
$protectedBranchesInput
.
on
(
'
change
'
,
()
=>
this
.
updateProtectedBranches
());
this
.
$table
.
on
(
'
click
'
,
'
.js-delete-mirror
'
,
event
=>
this
.
deleteMirror
(
event
));
...
...
app/assets/javascripts/mirrors/ssh_mirror.js
View file @
538ece0f
import
$
from
'
jquery
'
;
import
_
from
'
underscore
'
;
import
{
escape
as
esc
}
from
'
lodash
'
;
import
{
__
}
from
'
~/locale
'
;
import
axios
from
'
~/lib/utils/axios_utils
'
;
import
Flash
from
'
~/flash
'
;
...
...
@@ -162,7 +162,7 @@ export default class SSHMirror {
const
$fingerprintsList
=
this
.
$hostKeysInformation
.
find
(
'
.js-fingerprints-list
'
);
let
fingerprints
=
''
;
sshHostKeys
.
fingerprints
.
forEach
(
fingerprint
=>
{
const
escFingerprints
=
_
.
escape
(
fingerprint
.
fingerprint
);
const
escFingerprints
=
esc
(
fingerprint
.
fingerprint
);
fingerprints
+=
`<code>
${
escFingerprints
}
</code>`
;
});
...
...
changelogs/unreleased/196660-replace-underscore-with-lodash-for-app-assets-javascripts-mirrors.yml
0 → 100644
View file @
538ece0f
---
title
:
Replace underscore with lodash for ./app/assets/javascripts/mirrors
merge_request
:
24967
author
:
Jacopo Beschi @jacopo-beschi
type
:
changed
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment