Merge branch '343661-make-ci-cd-analytics-visible-as-admin' into 'master'

Make DORA data visible for admins

See merge request gitlab-org/gitlab!76204

ee/app/policies/ee/group_policy.rb

@@ -185,7 +185,7 @@ module EE
       rule { has_access & group_activity_analytics_available }
         .enable :read_group_activity_analytics
 
-      rule { reporter & dora4_analytics_available }
+      rule { (admin | reporter) & dora4_analytics_available }
         .enable :read_dora4_analytics
 
       rule { reporter & group_repository_analytics_available }

ee/app/policies/ee/project_policy.rb

@@ -357,7 +357,7 @@ module EE
 
       rule { can?(:read_merge_request) & code_review_analytics_enabled }.enable :read_code_review_analytics
 
-      rule { reporter & dora4_analytics_available }
+      rule { (admin | reporter) & dora4_analytics_available }
         .enable :read_dora4_analytics
 
       rule { reporter & project_merge_request_analytics_available }

ee/spec/policies/group_policy_spec.rb

@@ -196,15 +196,23 @@ RSpec.describe GroupPolicy do
   end
 
   context 'when dora4 analytics is available' do
-    let(:current_user) { developer }
-
     before do
       stub_licensed_features(dora4_analytics: true)
     end
 
+    context 'when the user is a developer' do
+      let(:current_user) { developer }
+
       it { is_expected.to be_allowed(:read_dora4_analytics) }
     end
 
+    context 'when the user is an admin', :enable_admin_mode do
+      let(:current_user) { admin }
+
+      it { is_expected.to be_allowed(:read_dora4_analytics) }
+    end
+  end
+
   context 'when dora4 analytics is not available' do
     let(:current_user) { developer }
 

ee/spec/policies/project_policy_spec.rb

@@ -1286,14 +1286,22 @@ RSpec.describe ProjectPolicy do
   end
 
   context 'when dora4 analytics is available' do
-    let(:current_user) { developer }
-
     before do
       stub_licensed_features(dora4_analytics: true)
     end
 
+    context 'when the user is a developer' do
+      let(:current_user) { developer }
+
+      it { is_expected.to be_allowed(:read_dora4_analytics) }
+    end
+
+    context 'when the user is an admin', :enable_admin_mode do
+      let(:current_user) { admin }
+
       it { is_expected.to be_allowed(:read_dora4_analytics) }
     end
+  end
 
   context 'when dora4 analytics is not available' do
     let(:current_user) { developer }