Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
56fbe4e1
Commit
56fbe4e1
authored
Nov 30, 2020
by
Sarah Groff Hennigh-Palermo
Committed by
Andrew Fontaine
Nov 30, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Pipeline Graph Structural Update: Cleanup CSS and Accessors
parent
a8bfc498
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
23 deletions
+7
-23
app/assets/javascripts/pipelines/components/graph/job_item.vue
...ssets/javascripts/pipelines/components/graph/job_item.vue
+3
-3
app/assets/javascripts/pipelines/components/graph/stage_column_component.vue
...pts/pipelines/components/graph/stage_column_component.vue
+4
-5
app/assets/stylesheets/page_bundles/pipeline.scss
app/assets/stylesheets/page_bundles/pipeline.scss
+0
-15
No files found.
app/assets/javascripts/pipelines/components/graph/job_item.vue
View file @
56fbe4e1
...
...
@@ -4,7 +4,7 @@ import ActionComponent from './action_component.vue';
import
JobNameComponent
from
'
./job_name_component.vue
'
;
import
{
sprintf
}
from
'
~/locale
'
;
import
delayedJobMixin
from
'
~/jobs/mixins/delayed_job_mixin
'
;
import
{
access
ors
}
from
'
./accessors
'
;
import
{
access
Value
}
from
'
./accessors
'
;
import
{
REST
}
from
'
./constants
'
;
/**
...
...
@@ -79,10 +79,10 @@ export default {
return
this
.
dropdownLength
===
1
?
'
viewport
'
:
'
scrollParent
'
;
},
detailsPath
()
{
return
this
.
status
[
accessors
[
this
.
dataMethod
].
detailsPath
]
;
return
accessValue
(
this
.
dataMethod
,
'
detailsPath
'
,
this
.
status
)
;
},
hasDetails
()
{
return
this
.
status
[
accessors
[
this
.
dataMethod
].
hasDetails
]
;
return
accessValue
(
this
.
dataMethod
,
'
hasDetails
'
,
this
.
status
)
;
},
status
()
{
return
this
.
job
&&
this
.
job
.
status
?
this
.
job
.
status
:
{};
...
...
app/assets/javascripts/pipelines/components/graph/stage_column_component.vue
View file @
56fbe4e1
...
...
@@ -5,7 +5,7 @@ import JobItem from './job_item.vue';
import
JobGroupDropdown
from
'
./job_group_dropdown.vue
'
;
import
ActionComponent
from
'
./action_component.vue
'
;
import
{
GRAPHQL
}
from
'
./constants
'
;
import
{
access
ors
}
from
'
./accessors
'
;
import
{
access
Value
}
from
'
./accessors
'
;
export
default
{
components
:
{
...
...
@@ -39,7 +39,6 @@ export default {
default
:
()
=>
({}),
},
},
accessors
,
titleClasses
:
[
'
gl-font-weight-bold
'
,
'
gl-pipeline-job-width
'
,
...
...
@@ -56,8 +55,8 @@ export default {
},
},
methods
:
{
get
Accessor
(
property
)
{
return
access
ors
[
GRAPHQL
][
property
]
;
get
GroupId
(
group
)
{
return
access
Value
(
GRAPHQL
,
'
groupId
'
,
group
)
;
},
groupId
(
group
)
{
return
`ci-badge-
${
escape
(
group
.
name
)}
`
;
...
...
@@ -87,7 +86,7 @@ export default {
<div
v-for=
"group in groups"
:id=
"groupId(group)"
:key=
"g
roup[getAccessor('groupId')]
"
:key=
"g
etGroupId(group)
"
data-testid=
"stage-column-group"
class=
"gl-relative gl-mb-3 gl-white-space-normal gl-pipeline-job-width"
>
...
...
app/assets/stylesheets/page_bundles/pipeline.scss
View file @
56fbe4e1
...
...
@@ -129,17 +129,6 @@
overflow
:
auto
;
}
// Move to Gitlab UI
.gl-font-weight-100
{
font-weight
:
100
;
}
.gl-active-text-decoration-none
:active
,
.gl-focus-text-decoration-none
:focus
,
.gl-hover-text-decoration-none
:hover
{
text-decoration
:
none
;
}
// These are single-value classes to use with utility-class style CSS
// but to still access this variable. Do not add other styles.
.gl-pipeline-min-h
{
...
...
@@ -150,10 +139,6 @@
width
:
186px
;
}
.gl-pipeline-title-width
{
width
:
176px
;
}
.gl-build-content
{
@include
build-content
();
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment